Split trie-db test in a different crate. #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ordian
approved these changes
Aug 14, 2020
dvdplm
approved these changes
Aug 14, 2020
ordian
reviewed
Jan 5, 2021
Comment on lines
36
to
42
| use trie_db::{ | ||
| nibble_ops, NodeCodec, | ||
| Trie, TrieConfiguration, | ||
| TrieLayout, TrieMut, | ||
| }; | ||
| pub use trie_root::TrieStream; | ||
| pub mod node { | ||
| use trie_root::TrieStream; | ||
| mod node { |
There was a problem hiding this comment.
I'm not a fan of re-exports as well, but this is a test-support crate, and the re-exports improve ergonomics for some tests imports
There was a problem hiding this comment.
I realize I misunderstood your comment (I did not put back the doc tests).
There was a problem hiding this comment.
but in fact it would also need to reestablished the cyclic dependency. Nevermind.
ordian
added a commit
that referenced
this pull request
Jan 5, 2021
* master: Split trie-db test in a different crate. (#111)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR propose to move trie-db test into crate trie-db-test crate to remove the cyclic dependency and reexport from reference-trie.
This is far from being ideal, but seems more extensible (I would like to move some fuzzer code into tests but the cyclic dependency makes it difficult).