Skip to content
This repository has been archived by the owner on May 21, 2024. It is now read-only.

Check why testing with benchmark is taking so long. #214

Closed
hbulgarini opened this issue Jun 6, 2023 · 2 comments · Fixed by #241
Closed

Check why testing with benchmark is taking so long. #214

hbulgarini opened this issue Jun 6, 2023 · 2 comments · Fixed by #241
Assignees
Labels
bug Something isn't working

Comments

@hbulgarini
Copy link
Contributor

It seems that after #206, running the tests with benchmark feature is taking more than the double of it used to be.

@hbulgarini hbulgarini added the bug Something isn't working label Jun 6, 2023
@hbulgarini hbulgarini added this to the Trappist M1 / XCM v2 milestone Jun 6, 2023
@hbulgarini hbulgarini self-assigned this Jun 6, 2023
@kalaninja
Copy link
Contributor

We used to compile and run tests for trappist only. After #206 both trappist and stout are compiled and tested. We can probably try to reimplement feature flags to become able to compile trappist and stout separately. This will also allow to compare the compilation process for both and make sure that compilation artifacts are reused properly.

@kalaninja
Copy link
Contributor

kalaninja commented Jun 28, 2023

I reintroduced feature flags with #241. Currently not running tests for stout, since it doesn't have much. There also was a problem with not enough space to collect cache after running tests during test stage, was fixed in #241 too. Also the building time will improve after polkadot version upgrade, because hostperfcheck feature became optional. (In 0.9.37 it cannot be disabled and it brings kusama runtime in scope).

The only issue that remains unsolved is the github cache size limit of 10gb per repository. Cache size of a single build is 6gb (tests) + 1.2gb (check) = 7.2gb. If we have 2 branches using different cache keys (currently main and xcmv3-dev) they eliminate each others cache.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants