Disable unleash-check

[joao-paulo-parity]

This line for cargo unleash check ${CARGO_UNLEASH_PKG_DEF} is failing consistently. The last time the status passed on master was on 2021-08-02 and it had been intermittently failing even before that. I suggested to @TriplEight that the check should be disabled until it's taken care of.

cc @gnunicorn

[skip ci]

[bkchr]

This will work again after merging this pr: #8615

Which should happen in the near future.

[bkchr]

So, not sure we need this.

[joao-paulo-parity]

The point of statuses is that developers should care about them and take action when they are failing. If the solution is a "work-in-progress" then disabling the check temporarily is the proper workaround, instead allowing it to fail, since it will always fail, thus providing no value whatsoever. It literally is just noise right now. I think not disabling it in #9474 was a mistake.

I remember when the simnet status was failing often and it was requested for it to be disabled. What is to say about a status which always fails? Not only it does not make sense to have it enabled, but it also might annoy people who see Substrate as perma-red on master for more than a month.

So, not sure we need this.

Fair enough. This is not breaking anything so I'm not interested in pushing it forward if there's any resistance whatsoever. Feel free to re-open and follow up on this if there's interest.

[bkchr]

@joao-paulo-parity I get your point and I'm with you that we should have disabled this from the beginning :D

If you like, we can merge it and you push a commit to the pr mentioned above to enable it there again? If you like this idea, reopen and I approve this pr :)

[joao-paulo-parity]

I did not push a commit on #8615 (felt out-of-place for me, I don't know...) but left a comment there to re-enable the check once it's ready.

[joao-paulo-parity]

bot merge

[ghost]

Trying merge.