This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Transactional updates in the state-db #1616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rphmeier
reviewed
Jan 29, 2019
|
Are you sure it closes #1602 - I could see that finalization still comes before import. |
svyatonik
reviewed
Jan 30, 2019
| @@ -886,10 +790,14 @@ impl<Block> client::backend::Backend<Block, Blake2Hasher> for Backend<Block> whe | |||
| drop(leaves); | |||
| } | |||
|
|
|||
| for (hash, number, is_best, is_finalized) in meta_updates { | |||
There was a problem hiding this comment.
Just curious - why do we need to replace one loop (inside if !operation.finalized_blocks.is_empty() {) with two (inside operation.pending_block.is_some() and operation.pending_block.is_none())? Does it fix something?
There was a problem hiding this comment.
- In case case
finalized_blocksare specified metadata for these should be set before thepending_block - All metadata should be updated after the transaction is committed.
|
|
gavofyork
added
the
U1-asap
|
Needs a resolve |
gavofyork
added
F0-consensus
U0-drop_everything
rphmeier
approved these changes
Jan 30, 2019
rphmeier
added
A8-looksgood
and removed
A0-please_review
arkpar
added a commit
that referenced
this pull request
Jan 30, 2019
rphmeier
pushed a commit
that referenced
this pull request
Jan 31, 2019
This was referenced Jan 31, 2019
MTDK1
pushed a commit
to bdevux/substrate
that referenced
this pull request
Apr 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.