Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Fix spellcheck for benchmarking comments #14535

Merged
merged 4 commits into from
Jul 7, 2023
Merged

Fix spellcheck for benchmarking comments #14535

merged 4 commits into from
Jul 7, 2023

Conversation

ggwpez
Copy link
Member

@ggwpez ggwpez commented Jul 7, 2023 •
edited
Loading

Escape everything that could cause spellcheck issues with backticks.
Also removes the Skipped from the comments - it was just wrong (and confusing).

ggwpez added 2 commits July 7, 2023 15:43
@ggwpez
Benchmarking spellcheck fix
70ffcff 
Put everything that could cause spellcheck issues into backticks.

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Also in templates
762049d 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit T1-runtime This PR/Issue is related to the topic “runtime”. labels Jul 7, 2023
@ggwpez ggwpez requested a review from a team July 7, 2023 14:04
@ggwpez
Copy link
Member Author

ggwpez commented Jul 7, 2023

bot bench $ pallet dev pallet-balances

@command-bot
Copy link

command-bot bot commented Jul 7, 2023 •
edited
Loading

@ggwpez https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3147774 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet dev pallet-balances. Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 4-dba939ff-bae8-4693-837a-c0f7e50c2a0b to cancel this command or bot cancel to cancel all commands in this pull request.

s0me0ne-unkn0wn
s0me0ne-unkn0wn approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@s0me0ne-unkn0wn s0me0ne-unkn0wn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@paritytech-ci paritytech-ci requested review from a team July 7, 2023 14:44
@command-bot
Copy link

command-bot bot commented Jul 7, 2023

@ggwpez Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet dev pallet-balances has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3147774 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3147774/artifacts/download.

@ggwpez
Copy link
Member Author

ggwpez commented Jul 7, 2023

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot paritytech-processbot bot merged commit 70c0547 into master Jul 7, 2023
@paritytech-processbot paritytech-processbot bot deleted the oty-fix-spell branch July 7, 2023 15:33
@sacha-l sacha-l mentioned this pull request Jul 17, 2023
Merged
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
@ggwpez @nathanwhit
Fix spellcheck for benchmarking comments (paritytech#14535)
dbbcb1b 
* Benchmarking spellcheck fix

Put everything that could cause spellcheck issues into backticks.

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Also in templates

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet-balances

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: command-bot <>
@crystalin crystalin mentioned this pull request Oct 20, 2023
Closed
@JesseAbram JesseAbram mentioned this pull request Oct 26, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@s0me0ne-unkn0wn s0me0ne-unkn0wn s0me0ne-unkn0wn approved these changes

@pgherveou pgherveou pgherveou approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit T1-runtime This PR/Issue is related to the topic “runtime”.
Projects
Benchmarking and Weights
Status: Done
Runtime / FRAME
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ggwpez @pgherveou @s0me0ne-unkn0wn