This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Bump wasmtime to 6.0.0
#13429
Merged
Bump wasmtime to 6.0.0
#13429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koute
added
A0-please_review
michalkucharczyk
approved these changes
Feb 21, 2023
bkchr
approved these changes
Feb 21, 2023
|
bot merge |
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* Bump `wasmtime` to 6.0.0 * Disable cranelift egraphs
ukint-vs
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Apr 10, 2023
* Bump `wasmtime` to 6.0.0 * Disable cranelift egraphs
ukint-vs
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Apr 13, 2023
* Bump `wasmtime` to 6.0.0 * Disable cranelift egraphs
breathx
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Apr 22, 2023
* Bump `wasmtime` to 6.0.0 * Disable cranelift egraphs
15 tasks
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
* Bump `wasmtime` to 6.0.0 * Disable cranelift egraphs
kayabaNerve
added a commit
to serai-dex/substrate
that referenced
this pull request
Aug 23, 2023
Substrate prior disabled egraph-based optimizations due to its performance impact on pallets-contract (paritytech#13429). This commit performs the upgrade without benchmarking. Why? 1) pallets-contract isn't in-tree. 2) The only option now is egraph based optimizations, making this inevitable. 3) A preference for security and simplicity over performance. The second reason doesn't hold. We could wait until egraph based performance is equivalent or better, and then while it's still inevitable, it'd have been delayed long enough to not be an issue. The third reason is the real one. By not upgrading, we missed out on performance and security updates. While none critical, most appreciated. This also reduces the size of our tree, improving compilation times and supply chain scope. For benefits introduced with wasmtime 12, please see: 1) Improved native call performance (since wasmtime 9) 2) Wider SIMD support (since wasmtime 9, further improved in 11) 3) Fixing of a soundness issue (wasmtime issue 6509) 4) Misc performance improvements
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
wasmtimeto 6.0.0.This new version includes my fix to make LTO work again, so we can finally get rid of our own
wasmtimefork.Also of particular note here is that
wasmtime6.0.0 enabled a new optimization framework which heavily regresses the contracts pallet's performance (cc @athei); I still haven't finished investigating why exactly this happens, but for the time being we can just revert this back to 5.0.0's behavior by changing the relevant option when initializingwasmtime. Otherwise the performance looks to be mostly unchanged.