Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

BlockId removal: refactor: BlockBackend::block|block_status #13014

Merged
merged 5 commits into from
Jan 2, 2023

Conversation

michalkucharczyk
Copy link
Contributor

@michalkucharczyk michalkucharczyk commented Dec 23, 2022

It changes the arguments of:

  • BlockBackend::block
  • BlockBackend::block_status

method from: BlockId<Block> to: Block::Hash

This PR is part of BlockId::Number refactoring analysis (paritytech/polkadot-sdk#53)

polkadot companion: paritytech/polkadot#6477
cumulus companion: paritytech/cumulus#2041

It changes the arguments of:
-  `BlockBackend::block`
-  `BlockBackend::block_status`

method from: `BlockId<Block>` to: `Block::Hash`

This PR is part of BlockId::Number refactoring analysis (paritytech/substrate#11292)
@michalkucharczyk michalkucharczyk added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Dec 23, 2022
@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Dec 23, 2022
@dmitry-markin dmitry-markin requested a review from a team December 23, 2022 18:58
client/service/test/src/client/mod.rs Outdated Show resolved Hide resolved
client/service/test/src/client/mod.rs Outdated Show resolved Hide resolved
client/service/test/src/client/mod.rs Outdated Show resolved Hide resolved
client/service/test/src/client/mod.rs Outdated Show resolved Hide resolved
client/service/test/src/client/mod.rs Outdated Show resolved Hide resolved
client/service/test/src/client/mod.rs Outdated Show resolved Hide resolved
client/service/test/src/client/mod.rs Outdated Show resolved Hide resolved
primitives/consensus/common/src/block_validation.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 (code-wise; don't know enough to reason about business logic)

Co-authored-by: Bastian Köcher <git@kchr.de>
@michalkucharczyk
Copy link
Contributor Author

bot rebase

@paritytech-processbot
Copy link

Rebased

@michalkucharczyk
Copy link
Contributor Author

bot merge

@paritytech-processbot
Copy link

Error: "Check reviews" status is not passing for paritytech/cumulus#2041

@michalkucharczyk
Copy link
Contributor Author

bot merge

@paritytech-processbot paritytech-processbot bot merged commit bcee526 into master Jan 2, 2023
@paritytech-processbot paritytech-processbot bot deleted the mku-blockid-blockbackend-block branch January 2, 2023 09:42
ltfschoen pushed a commit to ltfschoen/substrate that referenced this pull request Feb 22, 2023
…ch#13014)

* BlockId removal: refactor: BlockBackend::block|block_status

It changes the arguments of:
-  `BlockBackend::block`
-  `BlockBackend::block_status`

method from: `BlockId<Block>` to: `Block::Hash`

This PR is part of BlockId::Number refactoring analysis (paritytech/substrate#11292)

* non-obvious reworks

* doc fix

* Apply suggestions from code review

Co-authored-by: Bastian Köcher <git@kchr.de>

Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: parity-processbot <>
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
…ch#13014)

* BlockId removal: refactor: BlockBackend::block|block_status

It changes the arguments of:
-  `BlockBackend::block`
-  `BlockBackend::block_status`

method from: `BlockId<Block>` to: `Block::Hash`

This PR is part of BlockId::Number refactoring analysis (paritytech/substrate#11292)

* non-obvious reworks

* doc fix

* Apply suggestions from code review

Co-authored-by: Bastian Köcher <git@kchr.de>

Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: parity-processbot <>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
Status: done
Development

Successfully merging this pull request may close these issues.

4 participants