Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Enforce that ProtocolId and the notifications protocol names should be UTF-8 #6660

Closed
tomaka opened this issue Jul 15, 2020 · 1 comment · Fixed by #6967
Closed

Enforce that ProtocolId and the notifications protocol names should be UTF-8 #6660

tomaka opened this issue Jul 15, 2020 · 1 comment · Fixed by #6967

Comments

@tomaka
Copy link
Contributor

tomaka commented Jul 15, 2020

The ProtocolId (ksmcc, dot, etc.) is, in practice, always a string. But at some point within the code we convert it into bytes, then employ shenanigans to turn it back into a string.

We should entirely remove maybe_utf8_bytes_to_string and enforce that ProtocolId is a string.

@tomaka tomaka changed the title Enforce that ProtocolId should be UTF-8 Enforce that ProtocolId and the notifications protocol names should be UTF-8 Aug 25, 2020
@tomaka
Copy link
Contributor Author

tomaka commented Aug 25, 2020

I've re-purposes this issue to cover both ProtocolId and the notification protocols names.

This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant