Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Expose previous GRANDPA round's missed votes in grandpa_roundState RPC #6271

Open
wpank opened this issue Jun 5, 2020 · 3 comments
Open
Assignees
Labels
J0-enhancement An additional feature request. U3-nice_to_have Issue is worth doing eventually. Z3-substantial Can be fixed by an experienced coder with a working knowledge of the codebase.

Comments

@wpank
Copy link

wpank commented Jun 5, 2020

Right now the current behavior when calling thegrandpa_roundState RPC call is dumping the internal state of GRANDPA, which can include the previous round, background, if it is still in progress.

A useful addition to this endpoint would be to include the previous round's missed votes, regardless of whether the previous round has terminated not, as this will give a strong alert-able condition for a validator if their node is not working correctly. This is also useful for alerting from nodes that are not connected to the validating infrastructure.

@wpank wpank added J0-enhancement An additional feature request. M6-rpcapi U3-nice_to_have Issue is worth doing eventually. Z3-substantial Can be fixed by an experienced coder with a working knowledge of the codebase. labels Jun 5, 2020
@dillu24
Copy link

dillu24 commented Jul 20, 2020

Since the rounds change frequently, would there be any way of accessing historical rounds? Because previous round data would be lost immediately.

@dillu24
Copy link

dillu24 commented Sep 13, 2021

Has there been any movement with regards to this issue? For PANIC we would like to query historical rounds to try and detect whether validators are participating in GRANDPA consensus.

@andresilva
Copy link
Contributor

We added this to the roadmap so it's planned to be tackled but most likely will only happen next year. In the meantime Darwinia has developed a tool for monitoring which maybe suits your use case: https://github.com/darwinia-network/grandma

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
J0-enhancement An additional feature request. U3-nice_to_have Issue is worth doing eventually. Z3-substantial Can be fixed by an experienced coder with a working knowledge of the codebase.
Projects
None yet
Development

No branches or pull requests

4 participants