Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Failed to open peer storage #404

Closed
chevdor opened this issue Jul 23, 2018 · 2 comments
Closed

Failed to open peer storage #404

chevdor opened this issue Jul 23, 2018 · 2 comments
Assignees
Labels
I4-annoyance The client behaves within expectations, however this “expected behaviour” itself is at issue.

Comments

@chevdor
Copy link
Contributor

chevdor commented Jul 23, 2018

This issue is more to document the problem and the solution. I don´t think a fix is worth it.
Feel free to comment/close the issue once read.
CC @gavofyork (I think you changed things on the topic recently).

Details

nodes.json new format:

{"QmRMGcQh69t8a8YwzHkofVo9SFr7ffggUwhAYjVSTChmrd":{"addrs":[["/ip4/104.211.54.233/tcp/30333",3155132328031937]]},"QmSz8qCADMmi92QB8dTqMPu56JYQQKZBAHz7y8KXjvqcvW":{"addrs":[["/ip4/40.117.153.33/tcp/30333",3155132328031937]]},"QmWCnXrhM1in1qPqVT3rDXQEJHedAzbPDMimdjqy2P9fGn":{"addrs":[["/ip4/104.211.48.51/tcp/30333",3155132328031937]]},"QmWzYU5X1NpFrprD1YZF5Lcj9aE5WF4QEg5FpvQx5XGWG7":{"addrs":[["/ip4/40.114.120.164/tcp/30333",3155132328031937]]},"QmYPx99i3H8EKXrvYHTBwqz3jjFC1kBfkvmSKd2h9zwQFr":{"addrs":[["/ip4/104.211.48.247/

Older format:

  "nodes": [
    {
      "url": "enode://690f4c344d25273eba0fa95463be214cf7c1720120cdad32d46a52483441107167720cd53b072240649d3ae6a6a42969871df983e14b7ec3327acc94195aeb23@10.5.0.184:30300",
      "last_contact": {
        "failure": 1531810202
      }
    },
    {
      "url": "enode://373ad6196df2322a931e396642c38932c85e8f481e4e3bfbff63f20700a67c17a4a700f3e101ef151e3de2bd5da647719619fdbb5820b4fc39aec7f1414ec46c@188.15.33.41:30303",
      "last_contact": {
        "failure": 1531810202
      }
    },
    ...

When a node starts and nodes.json contains old data, it reports Failed to open peer storage and say the peer data will not be saved.

Either we do a fix that wipes the old file and move on, or we document that users need to delete the file (which I kinda do in this issue :))

@tomaka
Copy link
Contributor

tomaka commented Jul 23, 2018

Still needs a fix so that the code automatically deletes the invalid peer storage.

@tomaka tomaka added the I4-annoyance The client behaves within expectations, however this “expected behaviour” itself is at issue. label Jul 23, 2018
@chevdor
Copy link
Contributor Author

chevdor commented Jul 23, 2018

I can take care of a fix.

chevdor added a commit to chevdor/substrate that referenced this issue Jul 23, 2018
@chevdor chevdor self-assigned this Jul 23, 2018
chevdor added a commit to chevdor/substrate that referenced this issue Jul 24, 2018
gavofyork pushed a commit that referenced this issue Jul 27, 2018
* Reset peers.json if the content is not loadable

Fix #404

* Whitespace
lamafab pushed a commit to lamafab/substrate that referenced this issue Jun 16, 2020
liuchengxu pushed a commit to chainx-org/substrate that referenced this issue Aug 23, 2021
* Impl `From` instead of impl `Into`
* Remove `Deref` impl of `GenericTrusteeSessionInfo`
* Add doc for some types
* Remove useless `GenericAllSessionInfo` type

Signed-off-by: koushiro <koushiro.cqx@gmail.com>
liuchengxu pushed a commit to autonomys/substrate that referenced this issue Jun 3, 2022
Add support for building runtime and executables via manual trigger
helin6 pushed a commit to boolnetwork/substrate that referenced this issue Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
I4-annoyance The client behaves within expectations, however this “expected behaviour” itself is at issue.
Projects
None yet
Development

No branches or pull requests

2 participants