Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Add a networking message to enable/disable the Substrate protocol on connections #1702

Closed
tomaka opened this issue Feb 6, 2019 · 1 comment
Labels
J0-enhancement An additional feature request.
Milestone

Comments

@tomaka
Copy link
Contributor

tomaka commented Feb 6, 2019

At the moment, we assume that a connection can be in two states: open and talking the Substrate protocol, or closed.
If a node is full, is in reserved mode, or if the peer is banned, we simply close the connection in order to stop talking the Substrate protocol.

There's a potential third state: performing a Kademlia request, or in the future some off-chain pure-libp2p communication, where we don't have to talk the Substrate protocol.

We can already keep connections alive and deny request for the Substrate protocol; however we have no way to then indicate that we will now start accepting the Substrate protocol if we denied it earlier.
We therefore need to send some kind of message between the two nodes in order to indicate that.

@tomaka tomaka added the J0-enhancement An additional feature request. label Feb 6, 2019
@tomaka tomaka added this to the 1.0 (final) milestone Feb 6, 2019
@gavofyork gavofyork modified the milestones: 1.1, Ideas Nov 28, 2019
@tomaka
Copy link
Contributor Author

tomaka commented Jul 9, 2020

Closing this as it is covered by #5670

@tomaka tomaka closed this as completed Jul 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
J0-enhancement An additional feature request.
Projects
None yet
Development

No branches or pull requests

2 participants