Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Metadata Api should be optional #11743

Closed
1 task
JoshOrndorff opened this issue Jun 25, 2022 · 3 comments
Closed
1 task

Metadata Api should be optional #11743

JoshOrndorff opened this issue Jun 25, 2022 · 3 comments

Comments

@JoshOrndorff
Copy link
Contributor

JoshOrndorff commented Jun 25, 2022

Currently the Substrate client requires that every runtime implement the Metadata runtime Api. But not all runtimes will need this Api. When writing a simple runtime, probably without frame, you have to stub this runtime api with something like this

impl sp_api::Metadata<Block> for Runtime {
	fn metadata() -> OpaqueMetadata {
		OpaqueMetadata::new(vec![0])
	}
}

Is metadata intended for use in FRAME only? If so, I don't think it should be required.

cc @kianenigma

Tasks

  1. I4-refactor I7-refactor
    bkchr
@kianenigma kianenigma added the J2-unconfirmed Issue might be valid, but it’s not yet known. label Jul 1, 2022
@kianenigma
Copy link
Contributor

cc @bkchr @koute

@bkchr
Copy link
Member

bkchr commented Jul 1, 2022

I think it is probably because of the Metadata rpc? The client itself doesn't need the Metadata. In the future this will be fixed™

@kianenigma kianenigma removed the J2-unconfirmed Issue might be valid, but it’s not yet known. label Dec 30, 2022
@kianenigma
Copy link
Contributor

As far as I understood, similar to #14198, all such bounds would go away after paritytech/polkadot-sdk#27. If confirmed, let's close this one as well in favor of it.

@bkchr bkchr closed this as completed Aug 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: done
Development

No branches or pull requests

3 participants