Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Decouple TransactionPayment from polynomial #11278

Closed
kianenigma opened this issue Apr 25, 2022 · 0 comments · Fixed by #11415
Closed

Decouple TransactionPayment from polynomial #11278

kianenigma opened this issue Apr 25, 2022 · 0 comments · Fixed by #11415
Labels
I7-refactor Code needs refactoring. J0-enhancement An additional feature request. Z6-mentor An easy task where a mentor is available. Please indicate in the issue who the mentor could be.

Comments

@kianenigma
Copy link
Contributor

Sorry @nazar-pc I deleted my comment cause I didnt read any code, but now I did.

It is strange to me that there is a WeightToFeePolynomial trait at all.

Seems the trait should simply be WeightToFee with a single function fn calc that should be implemented, and this is what should be required in the pallet.

Then there should be a subtrait WeightToFeePolynomial, or just a struct, which implements WeightToFee but in the case of a polynomial.

Does that make sense? Then you can simply have Identity be the true identity without any polynomial bs.

Originally posted by @shawntabrizi in #11226 (comment)

@kianenigma kianenigma added I7-refactor Code needs refactoring. J0-enhancement An additional feature request. Z6-mentor An easy task where a mentor is available. Please indicate in the issue who the mentor could be. labels Apr 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
I7-refactor Code needs refactoring. J0-enhancement An additional feature request. Z6-mentor An easy task where a mentor is available. Please indicate in the issue who the mentor could be.
Projects
None yet
1 participant