Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Refactor benchmark command structure #11140

Closed
ggwpez opened this issue Mar 30, 2022 · 2 comments · Fixed by #11164
Closed

Refactor benchmark command structure #11140

ggwpez opened this issue Mar 30, 2022 · 2 comments · Fixed by #11164
Assignees
@ggwpez
Labels
I7-refactor Code needs refactoring. U2-some_time_soon Issue is worth doing soon. Z1-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder

Comments

@ggwpez
Copy link
Member

ggwpez commented Mar 30, 2022 •
edited
Loading

Instead of having benchmark, benchmark-block, benchmark-storage and benchmark-overhead they should all be sub-commands of benchmark for easier usage.
@ggwpez ggwpez added I7-refactor Code needs refactoring. U2-some_time_soon Issue is worth doing soon. Z1-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder labels Mar 30, 2022
@ggwpez ggwpez self-assigned this Mar 30, 2022
This was referenced Mar 30, 2022
Merged
Closed
This was referenced Apr 1, 2022
Open
Closed
Merged
@omadoyeabraham
Copy link
Contributor

@ggwpez I'm attempting this issue

@ggwpez
Copy link
Member Author

ggwpez commented Apr 26, 2022

This issue is already done. Maybe you can pick something from paritytech/polkadot-sdk#391 @omadoyeabraham ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ggwpez ggwpez

Labels
I7-refactor Code needs refactoring. U2-some_time_soon Issue is worth doing soon. Z1-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder
Projects
Benchmarking and Weights
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Sub-commands for benchmark paritytech/substrate
2 participants
@ggwpez @omadoyeabraham