chore: Optimize cache cleanup timer #601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

Bvegas882 wants to merge 1 commit into paritytech:master from Bvegas882:patch-1

Bvegas882 commented May 6, 2025

This PR improves the App component by properly managing the cache cleanup timer using React lifecycle methods.

Changes made:

Added a private cacheTimer property to store the timer reference
Moved the setInterval call from constructor to componentDidMount
Added proper cleanup in componentWillUnmount
Removed redundant comments

This change ensures that the timer is properly cleaned up when the component unmounts, preventing potential memory leaks and unnecessary re-renders.


          Update App.tsx

2aeb808

cla-bot-2021 bot commented May 6, 2025

User @Bvegas882, please sign the CLA here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet