This repository was archived by the owner on Jun 3, 2024. It is now read-only.
added author as an approval review #115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bullrich
force-pushed
the
bullrich/count-pr-owner
branch
from
7071894 to
3ab2293
Compare
Bullrich
force-pushed
the
bullrich/count-pr-owner
branch
13 times, most recently
from
2844b75 to
c9da1fe
Compare
Bullrich
force-pushed
the
bullrich/count-pr-owner
branch
from
c9da1fe to
a1efb5c
Compare
Bullrich
force-pushed
the
bullrich/count-pr-owner
branch
from
80153cc to
32b62cc
Compare
altaua
previously approved these changes
Jun 22, 2023
mordamax
approved these changes
Jun 23, 2023
This was referenced Jun 23, 2023
altaua
approved these changes
Jun 24, 2023
altaua
reviewed
Jun 24, 2023
| @@ -67,6 +68,12 @@ lint: | |||
| script: | |||
| - pre-commit run --all | |||
|
|
|||
| tests: | |||
| <<: *common-refs | |||
| stage: unit_test | |||
There was a problem hiding this comment.
Just ooc, why can't this go into the test stage together with the security-scan job?
There was a problem hiding this comment.
I decided to keep them separated just because their concerns are different.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the author of a PR as an approval. By doing this, if the author is part of the teams that need to review the PR, it will make him count as one required review less.
Fixes #104