Migrate pallet-tips to umbrella crate
#6532
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
User @bennethxyz, please sign the CLA here. |
92 tasks
|
@kianenigma @re-gius please review |
re-gius
added
R0-silent
|
please review @re-gius |
re-gius
reviewed
Jan 3, 2025
re-gius
reviewed
Jan 7, 2025
gui1117
reviewed
Jan 29, 2025
| @@ -654,7 +639,7 @@ impl<T: Config<I>, I: 'static> Pallet<T, I> { | |||
| /// 1. The number of entries in `Tips` should be equal to `Reasons`. | |||
| /// 2. Reasons exists for each Tip[`OpenTip.reason`]. | |||
| /// 3. If `OpenTip.finders_fee` is true, then OpenTip.deposit should be greater than zero. | |||
| #[cfg(any(feature = "try-runtime", test))] | |||
There was a problem hiding this comment.
curious why is this changed?
There was a problem hiding this comment.
mainly because of this
error[E0433]: failed to resolve: could not find `try_runtime` in `frame`
--> /polkadot-sdk/substrate/frame/tips/src/lib.rs:640:45
|
640 | pub fn do_try_state() -> Result<(), frame::try_runtime::TryRuntimeError> {
| ^^^^^^^^^^^ could not find `try_runtime` in `frame`
|
note: found an item that was configured out
--> /polkadot-sdk/substrate/frame/src/lib.rs:254:9
|
254 | pub mod try_runtime {
| ^^^^^^^^^^^
note: the item is gated here
--> /polkadot-sdk/substrate/frame/src/lib.rs:253:1
|
253 | #[cfg(any(feature = "try-runtime", test))]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^| <Test as crate::Config>::TipReportDepositBase::get() + | ||
| <Test as crate::Config>::DataDepositPerByte::get() * | ||
| <<Test as crate::Config>::TipReportDepositBase as TypedGet>::get() + | ||
| <<Test as crate::Config>::DataDepositPerByte as TypedGet>::get() * |
There was a problem hiding this comment.
Why is TypedGet not in the prelude? I guess because otherwise get is conflicting. Then it is good as it is.
| }, | ||
| weights::Weight, | ||
| }; | ||
| use core::str; | ||
|
|
| @@ -195,6 +181,7 @@ pub fn new_test_ext() -> sp_io::TestExternalities { | |||
| pub fn build_and_execute(test: impl FnOnce() -> ()) { | |||
| new_test_ext().execute_with(|| { | |||
| test(); | |||
| #[cfg(feature = "try-runtime")] | |||
There was a problem hiding this comment.
I think it was better before when the state was asserted in the test.
| @@ -631,10 +608,9 @@ fn report_awesome_and_tip_works_second_instance() { | |||
| } | |||
|
|
|||
| #[test] | |||
| #[cfg(feature = "try-runtime")] | |||
| ); | ||
| }) | ||
| } | ||
|
|
||
| #[test] | ||
| #[cfg(feature = "try-runtime")] |
| ); | ||
| }) | ||
| } | ||
|
|
||
| #[test] | ||
| #[cfg(feature = "try-runtime")] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #6504
Description
Modifying
pallet-tipsto usepolkadot-frame-sdkre-exports and adding a few I think relevant for other pallets.Review Notes
runtime::preludenow includesPalletId, I saw many other pallets use this in mock environments to distinguish instances of the same pallet and also identifiers for XCM.Added
ensureto top levelpreludeas it is also used in mock runtimes and other files acrossFRAME.polkadot address: 15rM9idTv1izwNFqPabfcT4jkqHDsEvHSa5fASAUZwZcS4Yw