[XCMv5]Remove XCM testnet NetworkIds #5390
Conversation
There was a problem hiding this comment.
You should not change the definition for existing XCM v3 and v4 versions, but instead, remove the test networks ids in the new upcoming XCM v5 version.
There is a PR for XCMv5: #4826
You should also change this PR's base branch to https://github.com/paritytech/polkadot-sdk/tree/xcm-v5 instead of master, to get your changes added to the xcm-v5 branch.
Oh, I am sorry that I don't know this PR. I will change it. |
…block()` (paritytech#5339) There was no need for it to be `&mut self` since block import can happen concurrently for different blocks and in many cases it was `&mut Arc<dyn BlockImport>` anyway 🤷♂️ Similar in nature to paritytech#4844
The CI isn't happy with the amount of output: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7035621/raw --------- Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
programskillforverification
force-pushed
the
remove-networkids
branch
from
9d38797
to
4f16f3c
Compare
programskillforverification
force-pushed
the
remove-networkids
branch
from
ed86293
to
5d15302
Compare
programskillforverification
requested review from
sorpaas and
a team
as code owners
There was a problem hiding this comment.
The XCM changes look good 👍
You need to clean up the current PR against xcm-v5 as it also contains unrelated changes coming from other master PRs.
@franciscoaguirre @bkontur besides the foreign assets ids, do we have any other affected storage items?
| let foreign_asset_id_location = Location::new( | ||
| 2, | ||
| [Junction::GlobalConsensus(NetworkId::ByGenesis(WESTEND_GENESIS_HASH))], | ||
| ); |
There was a problem hiding this comment.
Will also need a migration for the bridged assets registered as foreign assets on Rococo and Westend Asset Hubs.
Their IDs are changing now, storage items need migrating.
There was a problem hiding this comment.
Will also need a migration for the bridged assets registered as foreign assets on Rococo and Westend Asset Hubs.
Their IDs are changing now, storage items need migrating.
Migrates storage to v5?
There was a problem hiding this comment.
cc @franciscoaguirre since he looked at same migration for v3->v4
There was a problem hiding this comment.
@franciscoaguirre pls provide more info or ref about migration
There was a problem hiding this comment.
This will need multi-block migrations, which we don't have the setup for now. I need to work on getting that setup done anyway. When I'm done I'll update here.
cumulus/parachains/runtimes/bridge-hubs/bridge-hub-rococo/src/lib.rs
Outdated
Show resolved
Hide resolved
cumulus/parachains/runtimes/bridge-hubs/bridge-hub-westend/src/lib.rs
Outdated
Show resolved
Hide resolved
programskillforverification
changed the title
cumulus/parachains/runtimes/bridge-hubs/bridge-hub-rococo/src/lib.rs
Outdated
Show resolved
Hide resolved
…lib.rs Co-authored-by: Adrian Catangiu <adrian@parity.io>
|
The CI pipeline was cancelled due to failure one of the required jobs. |
Context
Close #5241, for more detail, please refer to RFC0108
Changes
RococoandWestendfromNetworkIdRococo Genesis HashandWestend Genesis Hash