Fix benchmark failures when using insecure_zero_ed flag
#5354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkchr
approved these changes
Aug 14, 2024
|
@TarekkMA can you please add a |
ggwpez
approved these changes
Aug 14, 2024
|
Review required! Latest push from author must always be reviewed |
bkchr
approved these changes
Aug 15, 2024
librelois
approved these changes
Aug 15, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 15, 2024
Currently, when the pallet is compiled with the `insecure_zero_ed flag`, benchmarks fail because the minimum balance is set to zero. The PR aims to resolve this issue by implementing a placeholder value for the minimum balance when the `insecure_zero_ed` flag is active. it ensures that benchmarks run successfully regardless of whether this flag is used or not
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
muharem
reviewed
Aug 20, 2024
| @@ -31,6 +31,14 @@ const SEED: u32 = 0; | |||
| // existential deposit multiplier | |||
| const ED_MULTIPLIER: u32 = 10; | |||
|
|
|||
| fn minimum_balance<T: Config<I>, I: 'static>() -> T::Balance { | |||
| if cfg!(feature = "insecure_zero_ed") { | |||
| 100u32.into() | |||
There was a problem hiding this comment.
this is not really correct, min balance is 0 in this case. I would rather fix specifically failing bench/es. this might lead to a wrong benchmark at least with insecure_zero_ed feature enabled
There was a problem hiding this comment.
I didn't check all of them, but most of them are just using this to set some balance or whatever. I don't think there is any problem in using 100 if the ED is zero.
Merged
via the queue into
paritytech:master
with commit Aug 28, 2024
1c4141a
175 of 178 checks passed
ordian
added a commit
that referenced
this pull request
Aug 29, 2024
* master: (39 commits) short-term fix for para inherent weight overestimation (#5082) CI: Add backporting bot (#4795) Fix benchmark failures when using `insecure_zero_ed` flag (#5354) Command bot GHA v2 - /cmd <cmd> (#5457) Remove pallet::getter usage from treasury (#4962) Bump blake2b_simd from 1.0.1 to 1.0.2 (#5404) Bump rustversion from 1.0.14 to 1.0.17 (#5405) Bridge zombienet tests: remove old command (#5434) polkadot-parachain: Add omni-node variant with u64 block number (#5269) Refactor verbose test (#5506) Use umbrella crate for minimal template (#5155) IBP Coretime Polkadot bootnodes (#5499) rpc server: listen to `ipv6 socket` if available and `--experimental-rpc-endpoint` CLI option (#4792) Update approval-voting-regression-bench (#5504) change try-runtime rpc domains (#5443) polkadot-parachain-bin: Remove contracts parachain (#5471) Add feature to allow Aura collator to use full PoV size (#5393) Adding stkd bootnodes (#5470) Make `PendingConfigs` storage item public (#5467) frame-omni-bencher maintenance (#5466) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when the pallet is compiled with the
insecure_zero_ed flag, benchmarks fail because the minimum balance is set to zero.The PR aims to resolve this issue by implementing a placeholder value for the minimum balance when the
insecure_zero_edflag is active. it ensures that benchmarks run successfully regardless of whether this flag is used or not