rpc server: listen to ipv6 socket if available and --experimental-rpc-endpoint CLI option
#4792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasad1
changed the title
…support-ipv6-sockets
niklasad1
changed the title
ipv6 by default and --rpc-listen-addrs
This is definitely very useful for multiple use cases and it is a feature that has been lacking for:
|
This format for allowing options to be passed with multiple listen addrs looks good to me! |
|
Very useful feature. One remark: can we avoid using whitespace in the arguments? It sometimes causes issues. Ideally, allow specifying multiple |
Yeah, it should work without whitespaces but I can add a test for it. |
niklasad1
commented
Aug 23, 2024
niklasad1
changed the title
ipv6 socket if available and --rpc-endpoint CLI optionipv6 socket if available and --experimental-rpc-endpoint CLI option
niklasad1
commented
Aug 28, 2024
4 tasks
ordian
added a commit
that referenced
this pull request
Aug 29, 2024
* master: (39 commits) short-term fix for para inherent weight overestimation (#5082) CI: Add backporting bot (#4795) Fix benchmark failures when using `insecure_zero_ed` flag (#5354) Command bot GHA v2 - /cmd <cmd> (#5457) Remove pallet::getter usage from treasury (#4962) Bump blake2b_simd from 1.0.1 to 1.0.2 (#5404) Bump rustversion from 1.0.14 to 1.0.17 (#5405) Bridge zombienet tests: remove old command (#5434) polkadot-parachain: Add omni-node variant with u64 block number (#5269) Refactor verbose test (#5506) Use umbrella crate for minimal template (#5155) IBP Coretime Polkadot bootnodes (#5499) rpc server: listen to `ipv6 socket` if available and `--experimental-rpc-endpoint` CLI option (#4792) Update approval-voting-regression-bench (#5504) change try-runtime rpc domains (#5443) polkadot-parachain-bin: Remove contracts parachain (#5471) Add feature to allow Aura collator to use full PoV size (#5393) Adding stkd bootnodes (#5470) Make `PendingConfigs` storage item public (#5467) frame-omni-bencher maintenance (#5466) ...
Merged
This was referenced Sep 9, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 11, 2024
Close #5677 I made a nit when I moved this code: https://github.com/paritytech/polkadot-sdk/blob/v1.14.0-rc1/substrate/client/service/src/lib.rs#L379-#L385 in #4792 Thus: - (ip.is_loopback(), RpcMethods::Auto) -> allow unsafe - (!ip.is_loopback(), RpcMethods::Auto) -> deny unsafe --------- Co-authored-by: ggwpez <ggwpez@users.noreply.github.com>
niklasad1
added a commit
that referenced
this pull request
Sep 12, 2024
Close #5677 I made a nit when I moved this code: https://github.com/paritytech/polkadot-sdk/blob/v1.14.0-rc1/substrate/client/service/src/lib.rs#L379-#L385 in #4792 Thus: - (ip.is_loopback(), RpcMethods::Auto) -> allow unsafe - (!ip.is_loopback(), RpcMethods::Auto) -> deny unsafe --------- Co-authored-by: ggwpez <ggwpez@users.noreply.github.com>
TarekkMA
reviewed
Nov 19, 2024
| .custom_tokio_runtime(cfg.tokio_handle.clone()) | ||
| .set_id_provider(RandomStringIdProvider::new(16)); | ||
|
|
||
| if let Some(provider) = id_provider2.take() { |
There was a problem hiding this comment.
Hello @niklasad1, Thank you for this contribution. I've a question about this change.
Why are we using .take() here. in the previous version this was not needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #3488, #4331
This changes/adds the following:
--experimental-rpc-endpointwhich allow to configure arbitrary listen addresses including the port, if this is enabled no other interfaces are enabled.So for instance in this PR it's now possible to start up three RPC endpoints as follows:
Needs to be addressed
1. Support binding to a random port if it's fails with the default stuff for backward compatible reasons2. How to sync that the rpc CLI params and that the rpc-listen-addr align, hard to maintain...3. Add similar warning prints for exposing unsafe methods on external interfaces..4. Inline todos + the hacky String conversion from rpc params.Cons with this PR
Manual strings parsing impl more error-prone than relying on clap....
//cc @jsdw @BulatSaif @PierreBesson @bkchr