Lift all dependencies (the big one) #4716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
ggwpez
requested review from
athei,
acatangiu,
sorpaas,
andresilva,
cheme,
a team and
koute
as code owners
muharem
reviewed
Jun 6, 2024
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
bkchr
approved these changes
Jun 24, 2024
| rand_core = { version = "0.6.2" } | ||
| rand_distr = { version = "0.4.3" } | ||
| rand_pcg = { version = "0.3.1" } | ||
| rayon = { version = "1.5.1" } |
There was a problem hiding this comment.
Suggested change
| rayon = { version = "1.5.1" } | |
| rayon = "1.5.1" |
Would have been nice for all of them, but just a nitty nitpick.
Generally some CI check to ensure we always add stuff with workspace = true would be good, but can come later.
There was a problem hiding this comment.
Would have been nice for all of them, but just a nitty nitpick.
👍
Generally some CI check to ensure we always add stuff with workspace = true would be good, but can come later.
There are some checks in place that should prevent the most obvious cases, but i did not yet check yet if its actually bullet-proof.
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
acatangiu
approved these changes
Jun 24, 2024
nazar-pc
reviewed
Jul 17, 2024
There was a problem hiding this comment.
This commit added 3 .wasm files, two of which are in the root of the repository, yet commit message simply says "Taplo".
Why?
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 18, 2024
There are slight changes required, after #4716. In order to follow the convention in the templates, we need to specify the internal template dependencies (runtime and a pallet) in the main `Cargo.toml`. Additionally, there are now dependencies with `path` in the main `Cargo.toml`, so we add a step with `psvm` to change those references to crate versions.
TarekkMA
pushed a commit
to moonbeam-foundation/polkadot-sdk
that referenced
this pull request
Aug 2, 2024
After preparing in paritytech#4633, we can lift also all internal dependencies up to the workspace. This does not actually change anything, but uses `workspace = true` for all dependencies. You can check it with: ```bash git checkout -q $(git merge-base oty-lift-all-deps origin/master) cargo tree -e features > master.out git checkout -q oty-lift-all-deps cargo tree -e features > new.out diff master.out new.out ``` It did not yet lift 100% of dependencies, some inside of `target.*` or some that had conflicting aliases introduced recently. But i will do these together in a follow-up with CI checks. Can be reproduced with [zepter](https://github.com/ggwpez/zepter/): `zepter transpose d lift-to-workspace "regex:.*" --version-resolver highest --skip-package "polkadot-sdk" --ignore-errors --fix`. --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
TarekkMA
pushed a commit
to moonbeam-foundation/polkadot-sdk
that referenced
this pull request
Aug 2, 2024
There are slight changes required, after paritytech#4716. In order to follow the convention in the templates, we need to specify the internal template dependencies (runtime and a pallet) in the main `Cargo.toml`. Additionally, there are now dependencies with `path` in the main `Cargo.toml`, so we add a step with `psvm` to change those references to crate versions.
sfffaaa
pushed a commit
to peaqnetwork/polkadot-sdk
that referenced
this pull request
Dec 27, 2024
After preparing in paritytech#4633, we can lift also all internal dependencies up to the workspace. This does not actually change anything, but uses `workspace = true` for all dependencies. You can check it with: ```bash git checkout -q $(git merge-base oty-lift-all-deps origin/master) cargo tree -e features > master.out git checkout -q oty-lift-all-deps cargo tree -e features > new.out diff master.out new.out ``` It did not yet lift 100% of dependencies, some inside of `target.*` or some that had conflicting aliases introduced recently. But i will do these together in a follow-up with CI checks. Can be reproduced with [zepter](https://github.com/ggwpez/zepter/): `zepter transpose d lift-to-workspace "regex:.*" --version-resolver highest --skip-package "polkadot-sdk" --ignore-errors --fix`. --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After preparing in #4633, we can lift also all internal dependencies up to the workspace.
This does not actually change anything, but uses
workspace = truefor all dependencies. You can check it with:It did not yet lift 100% of dependencies, some inside of
target.*or some that had conflicting aliases introduced recently. But i will do these together in a follow-up with CI checks.Can be reproduced with zepter:
zepter transpose d lift-to-workspace "regex:.*" --version-resolver highest --skip-package "polkadot-sdk" --ignore-errors --fix.