Use polkadot-ckb-merkle-mountain-range dependency #4562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serban300
added
R0-silent
svyatonik
approved these changes
May 24, 2024
bkontur
approved these changes
May 24, 2024
Merged
via the queue into
paritytech:master
with commit May 24, 2024
700d591
154 of 159 checks passed
hitchhooker
pushed a commit
to ibp-network/polkadot-sdk
that referenced
this pull request
Jun 5, 2024
We need to use the `polkadot-ckb-merkle-mountain-range` dependency published on `crates.io` in order to unblock the release of the `sp-mmr-primitives` crate
|
Please make sure to not pull from master when renaming things: This now lead to the latest release |
|
Using git dependencies is the general issue. We removed this one now, but looks like it is still present in the 1.12 release. |
TarekkMA
pushed a commit
to moonbeam-foundation/polkadot-sdk
that referenced
this pull request
Aug 2, 2024
We need to use the `polkadot-ckb-merkle-mountain-range` dependency published on `crates.io` in order to unblock the release of the `sp-mmr-primitives` crate
This was referenced Aug 21, 2024
acatangiu
pushed a commit
that referenced
this pull request
Oct 7, 2024
…#5897) # Description Polkadot SDK v1.12.0 `mmr-lib` dependency of the `sp-mmr-primitives` crate is set to the package `ckb-merkle-mountain-range` and pinned to the master branch of [this](https://github.com/paritytech/merkle-mountain-range) repo. The package name in that branch has changed to `polkadot-ckb-merkle-mountain-range`, which causes v1.12.0 to not compile. This PR does a simple backport to utilize the `polkadot-ckb-merkle-mountain-range` published package instead, and pins it to version 0.7.0, as was done in #4562
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to use the
polkadot-ckb-merkle-mountain-rangedependency published oncrates.ioin order to unblock the release of thesp-mmr-primitivescrate