Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt RemoteExternalities and its related types to be used with generic hash parameters #3953

Merged
merged 17 commits into from
Apr 8, 2024
Merged

Adapt RemoteExternalities and its related types to be used with generic hash parameters #3953

merged 17 commits into from
Apr 8, 2024

Conversation

lean-apple
Copy link
Contributor

Closes #3737

@ggwpez
Copy link
Member

ggwpez commented Apr 3, 2024

bot fmt

@command-bot
Copy link

command-bot bot commented Apr 3, 2024 •
edited
Loading

@ggwpez https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5764202 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 57-694d43e9-3f4e-448b-9c0c-f9034430fadc to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Apr 3, 2024

@ggwpez Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5764202 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5764202/artifacts/download.

@ggwpez ggwpez added the T1-FRAME This PR/Issue is related to core FRAME, the framework. label Apr 5, 2024
@lean-apple lean-apple changed the title Refactor RemoteExternalities and related types to depend on Hash/HashOutput Adapt RemoteExternalities and its related types to be used with generic hash parameters Apr 7, 2024
@lean-apple lean-apple marked this pull request as ready for review April 7, 2024 17:38
@lean-apple lean-apple requested review from cheme and a team as code owners April 7, 2024 17:38
ggwpez
ggwpez approved these changes Apr 8, 2024
View reviewed changes
Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits but looks good 👍

prdoc/pr_3953.prdoc Outdated Show resolved Hide resolved
prdoc/pr_3953.prdoc Outdated Show resolved Hide resolved
prdoc/pr_3953.prdoc Outdated Show resolved Hide resolved
substrate/utils/frame/remote-externalities/src/lib.rs Outdated Show resolved Hide resolved
substrate/utils/frame/remote-externalities/src/lib.rs Outdated Show resolved Hide resolved
substrate/utils/frame/remote-externalities/src/lib.rs Outdated Show resolved Hide resolved
lean-apple and others added 5 commits April 8, 2024 17:18
@lean-apple @ggwpez
Update prdoc/pr_3953.prdoc
d4778cd 
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@lean-apple @ggwpez
Update prdoc/pr_3953.prdoc
57caecb 
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@lean-apple @ggwpez
Update prdoc/pr_3953.prdoc
6d08db4 
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@lean-apple
remove unecessary bounds for impl
e7cbf22
@lean-apple
update prdoc
df2cd19
@ggwpez ggwpez requested a review from liamaharon April 8, 2024 16:15
bkchr
bkchr approved these changes Apr 8, 2024
View reviewed changes
substrate/utils/frame/remote-externalities/src/lib.rs Outdated Show resolved Hide resolved
prdoc/pr_3953.prdoc Outdated Show resolved Hide resolved
@bkchr bkchr enabled auto-merge April 8, 2024 20:52
@bkchr bkchr added this pull request to the merge queue Apr 8, 2024
Merged via the queue into paritytech:master with commit d733c77 Apr 8, 2024
130 of 135 checks passed
Ank4n pushed a commit that referenced this pull request Apr 9, 2024
@lean-apple @ggwpez
@bkchr @Ank4n
Adapt RemoteExternalities and its related types to be used with gen…
0cc0af3 
…eric hash parameters (#3953)

Closes  #3737

---------

Co-authored-by: command-bot <>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Bastian Köcher <git@kchr.de>
dharjeezy pushed a commit to dharjeezy/polkadot-sdk that referenced this pull request Apr 9, 2024
@lean-apple @ggwpez
@bkchr @dharjeezy
Adapt RemoteExternalities and its related types to be used with gen…
a952176 
…eric hash parameters (paritytech#3953)

Closes  paritytech#3737

---------

Co-authored-by: command-bot <>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Bastian Köcher <git@kchr.de>
@lean-apple lean-apple deleted the ln-remove-block-for-hash branch April 13, 2024 20:07
This was referenced Jun 5, 2024
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggwpez ggwpez ggwpez approved these changes

@bkchr bkchr bkchr approved these changes

@cheme cheme Awaiting requested review from cheme cheme is a code owner

@liamaharon liamaharon Awaiting requested review from liamaharon

Assignees
No one assigned
Labels
T1-FRAME This PR/Issue is related to core FRAME, the framework.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FRAME] RemoteExternalities should only require Hasher
3 participants
@lean-apple @ggwpez @bkchr