Pallet AURA: remove pallet::getter macro and write the corresponding code #3350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kianenigma
reviewed
Feb 16, 2024
davxy
changed the title
kianenigma
approved these changes
Feb 19, 2024
franciscoaguirre
added
the
R0-silent
63 tasks
muraca
suggested changes
Feb 19, 2024
k-gunjan
force-pushed
the
gunjan-remove-getter-macro-pallet-aura-issue-3330
branch
3 times, most recently
from
005d91f
to
05ab1ae
Compare
k-gunjan
force-pushed
the
gunjan-remove-getter-macro-pallet-aura-issue-3330
branch
from
9c1a94c
to
9b59665
Compare
|
As a breaking change, this requires the removal of the R0 label and a prdoc |
bkchr
approved these changes
Mar 18, 2024
Merged
via the queue into
paritytech:master
with commit Mar 18, 2024
816c072
130 of 132 checks passed
dharjeezy
pushed a commit
to dharjeezy/polkadot-sdk
that referenced
this pull request
Mar 24, 2024
…code (paritytech#3350) Removed the `pallet::getter` macro call from storage type definitions and added the corresponding implementations directly. fixes paritytech#3330 polkadot address: 14JzTPPUd8x8phKi8qLxHgNTnTMg6DUukCLXoWprejkaHXPz --------- Co-authored-by: Bastian Köcher <git@kchr.de>
|
tip? |
enddynayn
added a commit
to frequency-chain/frequency
that referenced
this pull request
Jul 30, 2024
- Update weights to reflect the new version. Notable Changes: - [System Callbacks](paritytech/polkadot-sdk#1781) - [Remove experimental flag](https://github.com/paritytech/polkadot-sdk/pull/3654/files) - [Remove pallet::getter macr](paritytech/polkadot-sdk#3350) - [Refactor APIs](https://github.com/paritytech/polkadot-sdk/pull/3817/files#diff-b02373af4015a8ebdf3a3f5be9ea0ce555b6e45331872e0465fd2f488177d383) For more details, please refer to: [Release Notes](https://github.com/paritytech/polkadot-sdk/releases/tag/polkadot-v1.10.0) issue-1922
enddynayn
added a commit
to frequency-chain/frequency
that referenced
this pull request
Jul 30, 2024
- Update weights to reflect the new version. Notable Changes: - [Remove experimental flag](https://github.com/paritytech/polkadot-sdk/pull/3654/files) - [Remove pallet::getter macr](paritytech/polkadot-sdk#3350) - [Refactor APIs](https://github.com/paritytech/polkadot-sdk/pull/3817/files#diff-b02373af4015a8ebdf3a3f5be9ea0ce555b6e45331872e0465fd2f488177d383) For more details, please refer to: [Release Notes](https://github.com/paritytech/polkadot-sdk/releases/tag/polkadot-v1.10.0) issue-1922
enddynayn
added a commit
to frequency-chain/frequency
that referenced
this pull request
Jul 30, 2024
- Update weights to reflect the new version. Notable Changes: - [Remove experimental flag](https://github.com/paritytech/polkadot-sdk/pull/3654/files) - [Remove pallet::getter macr](paritytech/polkadot-sdk#3350) - [Refactor APIs](https://github.com/paritytech/polkadot-sdk/pull/3817/files#diff-b02373af4015a8ebdf3a3f5be9ea0ce555b6e45331872e0465fd2f488177d383) For more details, please refer to: [Release Notes](https://github.com/paritytech/polkadot-sdk/releases/tag/polkadot-v1.10.0) issue-1928
enddynayn
added a commit
to frequency-chain/frequency
that referenced
this pull request
Jul 30, 2024
- Update weights to reflect the new version. Notable Changes: - [Remove experimental flag](https://github.com/paritytech/polkadot-sdk/pull/3654/files) - [Remove pallet::getter macr](paritytech/polkadot-sdk#3350) - [Refactor APIs](https://github.com/paritytech/polkadot-sdk/pull/3817/files#diff-b02373af4015a8ebdf3a3f5be9ea0ce555b6e45331872e0465fd2f488177d383) For more details, please refer to: [Release Notes](https://github.com/paritytech/polkadot-sdk/releases/tag/polkadot-v1.10.0) issue-1928
enddynayn
added a commit
to frequency-chain/frequency
that referenced
this pull request
Jul 30, 2024
- Upgrade Polkadot-sdk to v.1.10.0. - Update weights to reflect the new version. Notable Changes: - [Remove experimental flag](https://github.com/paritytech/polkadot-sdk/pull/3654/files) - [Remove pallet::getter macr](paritytech/polkadot-sdk#3350) - [Refactor APIs](https://github.com/paritytech/polkadot-sdk/pull/3817/files#diff-b02373af4015a8ebdf3a3f5be9ea0ce555b6e45331872e0465fd2f488177d383) For more details, please refer to: [Release Notes](https://github.com/paritytech/polkadot-sdk/releases/tag/polkadot-v1.10.0) issue-1928
enddynayn
added a commit
to frequency-chain/frequency
that referenced
this pull request
Jul 30, 2024
- Upgrade Polkadot-sdk to v.1.10.0. - Update weights to reflect the new version. Notable Changes: - [Remove experimental flag](https://github.com/paritytech/polkadot-sdk/pull/3654/files) - [Remove pallet::getter macr](paritytech/polkadot-sdk#3350) - [Refactor APIs](https://github.com/paritytech/polkadot-sdk/pull/3817/files#diff-b02373af4015a8ebdf3a3f5be9ea0ce555b6e45331872e0465fd2f488177d383) For more details, please refer to: [Release Notes](https://github.com/paritytech/polkadot-sdk/releases/tag/polkadot-v1.10.0) issue-1928
enddynayn
added a commit
to frequency-chain/frequency
that referenced
this pull request
Jul 30, 2024
- Upgrade Polkadot-sdk to v.1.10.0. - Update weights to reflect the new version. Notable Changes: - [Remove experimental flag](https://github.com/paritytech/polkadot-sdk/pull/3654/files) - [Remove pallet::getter macr](paritytech/polkadot-sdk#3350) - [Refactor APIs](https://github.com/paritytech/polkadot-sdk/pull/3817/files#diff-b02373af4015a8ebdf3a3f5be9ea0ce555b6e45331872e0465fd2f488177d383) For more details, please refer to: [Release Notes](https://github.com/paritytech/polkadot-sdk/releases/tag/polkadot-v1.10.0) issue-1928
enddynayn
added a commit
to frequency-chain/frequency
that referenced
this pull request
Jul 31, 2024
- Upgrade Polkadot-sdk to v.1.10.0. - Update weights to reflect the new version. Notable Changes: - [Remove experimental flag](https://github.com/paritytech/polkadot-sdk/pull/3654/files) - [Remove pallet::getter macr](paritytech/polkadot-sdk#3350) - [Refactor APIs](https://github.com/paritytech/polkadot-sdk/pull/3817/files#diff-b02373af4015a8ebdf3a3f5be9ea0ce555b6e45331872e0465fd2f488177d383) For more details, please refer to: [Release Notes](https://github.com/paritytech/polkadot-sdk/releases/tag/polkadot-v1.10.0) issue-1928
enddynayn
added a commit
to frequency-chain/frequency
that referenced
this pull request
Aug 1, 2024
- Upgrade Polkadot-sdk to v.1.10.0. - Update weights to reflect the new version. Notable Changes: - [Remove experimental flag](https://github.com/paritytech/polkadot-sdk/pull/3654/files) - [Remove pallet::getter macr](paritytech/polkadot-sdk#3350) - [Refactor APIs](https://github.com/paritytech/polkadot-sdk/pull/3817/files#diff-b02373af4015a8ebdf3a3f5be9ea0ce555b6e45331872e0465fd2f488177d383) For more details, please refer to: [Release Notes](https://github.com/paritytech/polkadot-sdk/releases/tag/polkadot-v1.10.0) issue-1928
enddynayn
added a commit
to frequency-chain/frequency
that referenced
this pull request
Aug 1, 2024
- Upgrade Polkadot-sdk 1.9.0 to 1.10.0 - Update weights to reflect the new version. Notable Changes: - [Remove experimental flag](https://github.com/paritytech/polkadot-sdk/pull/3654/files) - [Remove pallet::getter macro](paritytech/polkadot-sdk#3350) - [Refactor APIs](https://github.com/paritytech/polkadot-sdk/pull/3817/files#diff-b02373af4015a8ebdf3a3f5be9ea0ce555b6e45331872e0465fd2f488177d383) - [Refactor Unified Host Functions](paritytech/polkadot-sdk#3854) - [StorageWeightReclaim SignedExtension](https://github.com/paritytech/polkadot-sdk/pull/3002/files) For more details, please refer to: [Release Notes](https://github.com/paritytech/polkadot-sdk/releases/tag/polkadot-v1.10.0)
enddynayn
added a commit
to frequency-chain/frequency
that referenced
this pull request
Aug 1, 2024
- Upgrade Polkadot-sdk 1.9.0 to 1.10.0 - Update weights to reflect the new version. Notable Changes: - [Remove experimental flag](https://github.com/paritytech/polkadot-sdk/pull/3654/files) - [Remove pallet::getter macro](paritytech/polkadot-sdk#3350) - [Refactor APIs](https://github.com/paritytech/polkadot-sdk/pull/3817/files#diff-b02373af4015a8ebdf3a3f5be9ea0ce555b6e45331872e0465fd2f488177d383) - [Refactor Unified Host Functions](paritytech/polkadot-sdk#3854) - [StorageWeightReclaim SignedExtension](https://github.com/paritytech/polkadot-sdk/pull/3002/files) For more details, please refer to: [Release Notes](https://github.com/paritytech/polkadot-sdk/releases/tag/polkadot-v1.10.0) #1928 --------- Co-authored-by: enddynayn <enddynayn@users.noreply.github.com>
rustadot
pushed a commit
to rustadot/recurrency
that referenced
this pull request
Sep 5, 2024
- Upgrade Polkadot-sdk 1.9.0 to 1.10.0 - Update weights to reflect the new version. Notable Changes: - [Remove experimental flag](https://github.com/paritytech/polkadot-sdk/pull/3654/files) - [Remove pallet::getter macro](paritytech/polkadot-sdk#3350) - [Refactor APIs](https://github.com/paritytech/polkadot-sdk/pull/3817/files#diff-b02373af4015a8ebdf3a3f5be9ea0ce555b6e45331872e0465fd2f488177d383) - [Refactor Unified Host Functions](paritytech/polkadot-sdk#3854) - [StorageWeightReclaim SignedExtension](https://github.com/paritytech/polkadot-sdk/pull/3002/files) For more details, please refer to: [Release Notes](https://github.com/paritytech/polkadot-sdk/releases/tag/polkadot-v1.10.0) #1928 --------- Co-authored-by: enddynayn <enddynayn@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the
pallet::gettermacro call from storage type definitions and added the corresponding implementations directly.fixes #3330
polkadot address: 14JzTPPUd8x8phKi8qLxHgNTnTMg6DUukCLXoWprejkaHXPz