Implements a % cap on staking rewards from era inflation #1660

gpestana · 2023-09-21T09:22:28Z

This PR implements an (optional) cap of the era inflation that is allocated to staking rewards. The remaining is minted directly into the RewardRemainder account, which is the treasury pot account in Polkadot and Kusama.

The staking pallet now has a percent storage item, MaxStakersRewards, which defines the max percentage of the era inflation that should be allocated to staking rewards. The remaining era inflation (i.e. remaining = max_era_payout - staking_payout.min(staking_payout * MaxStakersRewards)) is minted directly into the treasury.

The MaxStakersRewards can be set by a privileged origin through the set_staking_configs extrinsic.

To finish

run benchmarks for westend-runtime

Replaces #1483
Closes #403

gpestana · 2023-09-22T10:59:51Z

bot bench polkadot-pallet --pallet=pallet_staking --runtime polkadot

command-bot · 2023-09-22T10:59:56Z

@gpestana https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3769934 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=runtime --runtime=polkadot --target_dir=polkadot --pallet=pallet_staking. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 2-6299fd2d-fa31-4702-9017-568fa5162db5 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2023-09-22T11:37:40Z

@gpestana Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=runtime --runtime=polkadot --target_dir=polkadot --pallet=pallet_staking has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3769934 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3769934/artifacts/download.

gpestana · 2023-09-22T12:18:23Z

bot bench substrate-pallet --pallet=pallet_staking

command-bot · 2023-09-22T12:18:28Z

"$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_staking was queued.

Comment bot cancel 6-b22a5e88-1858-41be-8925-d7eb4628e672 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2023-09-22T12:18:40Z

@gpestana Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_staking has finished. Result:

ValidationError: "id" is required
ValidationError: "id" is required
{"message":{"base":["Reference not found"]}}

polkadot/runtime/common/src/impls.rs

substrate/frame/staking/src/lib.rs

substrate/frame/staking/src/mock.rs

Ank4n

A small nit but otherwise looks good.

polkadot/runtime/common/src/impls.rs

substrate/frame/staking/src/mock.rs

substrate/frame/staking/src/pallet/mod.rs

polkadot/runtime/kusama/src/weights/pallet_staking.rs

polkadot/runtime/polkadot/src/weights/pallet_staking.rs

polkadot/runtime/westend/src/weights/pallet_staking.rs

…ining

gpestana · 2023-09-23T13:41:08Z

bot bench substrate-pallet --pallet=pallet_staking

command-bot · 2023-09-23T13:41:15Z

@gpestana https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3779467 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_staking. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 10-d6dfa0ed-f1ee-4795-8a98-728b4882ee01 to cancel this command or bot cancel to cancel all commands in this pull request.

…nto HEAD