Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove tracing-gum #5881

Open
alexggh opened this issue Oct 1, 2024 · 2 comments · May be fixed by #5965
Open

Remove tracing-gum #5881

alexggh opened this issue Oct 1, 2024 · 2 comments · May be fixed by #5965
Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. I9-optimisation An enhancement to provide better overall performance in terms of time-to-completion for a task. T0-node This PR/Issue is related to the topic “node”. T8-polkadot This PR/Issue is related to/affects the Polkadot network.

Comments

@alexggh
Copy link
Contributor

alexggh commented Oct 1, 2024

With jaeger tracing removed in #5875, the reason for tracing-gum existence is gone, so we should consider removing it as well.

See #5875 (review) for more details.
@alexggh alexggh added C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. I9-optimisation An enhancement to provide better overall performance in terms of time-to-completion for a task. T0-node This PR/Issue is related to the topic “node”. T8-polkadot This PR/Issue is related to/affects the Polkadot network. labels Oct 1, 2024
@alexggh alexggh mentioned this issue Oct 1, 2024
Merged
@AndreiEres
Copy link
Contributor

If gum::warn_if_frequent! is the only reason that holds it we can handle it in another place imho.

@programskillforverification
Copy link
Contributor

I would like to work on this

@programskillforverification programskillforverification linked a pull request Oct 8, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. I9-optimisation An enhancement to provide better overall performance in terms of time-to-completion for a task. T0-node This PR/Issue is related to the topic “node”. T8-polkadot This PR/Issue is related to/affects the Polkadot network.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove tracing-gum programskillforverification/polkadot-sdk
3 participants
@AndreiEres @alexggh @programskillforverification