-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get rid of libp2p
dependency in sc-authority-discovery
#4859
Comments
I'll have a go at this one |
So I can remove the libp2p dependency but I'm not quite sure how/where to replace with sc-network-types. I don't see libp2p being used anywhere in the sc-authority-discovery directory. |
If it is not being used, then the pr would just be about removing the crate and that's it ;) |
You have to look for re-exported types as well for example the KademliaKey from here: https://github.com/paritytech/polkadot-sdk/blob/master/substrate/client/authority-discovery/src/worker.rs#L45C30-L45C41. |
|
I don't see these types used in the public API, i.e., in sc_authority_discovery::service::Service. As for the types used internally (for example, in |
Hello! Started working on this issue, and would like to get a first feedback to see if I'm on the right track: |
Working now on removing |
@dmitry-markin , @bkchr, @lexnv : removed |
libp2p
types in authority-discovery should be replaced with network backend agnostic types fromsc-network-types
.The text was updated successfully, but these errors were encountered: