Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to polkadot-sdk-frame umbrella crate #4782

Open
2 tasks
Tracked by #5242
kianenigma opened this issue Jun 13, 2024 · 2 comments
Open
2 tasks
Tracked by #5242

Improvements to polkadot-sdk-frame umbrella crate #4782

kianenigma opened this issue Jun 13, 2024 · 2 comments
Assignees
Labels
T1-FRAME This PR/Issue is related to core FRAME, the framework. T11-documentation This PR/Issue is related to documentation.

Comments

@kianenigma
Copy link
Contributor

  • In the docs, explicitely mention the suggested use of prelude modules as the suggested way. Atm, this is not easily visibile in the first example that you would encounter, if you start digging into the crate docs.
  • Provide proper erros for #[cfg(not(feature = "experimental"))] that, instead of not working, provide a compiler error that says the frame crate is experimental.
@kianenigma kianenigma added T1-FRAME This PR/Issue is related to core FRAME, the framework. T11-documentation This PR/Issue is related to documentation. labels Jun 13, 2024
@kianenigma
Copy link
Contributor Author

kianenigma commented Aug 5, 2024

  • Make preludes use-able: As in: I should be able to write a reasonable pallet + runtime + tests + benchmarks without needing to use anything other than prelude::* + runtime::prelude::* + testing::prelude::* + benchmarking::prelude::*.
  • Either remove the experimental flag, or document the issues that need to be removed before we remove it.

@shawntabrizi
Copy link
Member

You are not exporting TokenError, and perhaps other DispatchError variants.

github-merge-queue bot pushed a commit that referenced this issue Oct 14, 2024
Use the umbrella crate for the parachain template

This covers almost all the dependencies. There are just a few exceptions
for which I created a separate issue:
#5993

Also related to: #4782
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T1-FRAME This PR/Issue is related to core FRAME, the framework. T11-documentation This PR/Issue is related to documentation.
Projects
None yet
Development

No branches or pull requests

3 participants