Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Benchmark CI check ignores debug assertions #4045

Open
ggwpez opened this issue Apr 9, 2024 · 0 comments
Open

Benchmark CI check ignores debug assertions #4045

ggwpez opened this issue Apr 9, 2024 · 0 comments
Labels
T12-benchmarks This PR/Issue is related to benchmarking and weights.

Comments

@ggwpez
Copy link
Member

ggwpez commented Apr 9, 2024 •
edited
Loading

Check short-benchmark builds the polkadot node without debug_assetions for the WASM.
This means that when it is later on used with Westend it skips the asserts.
Issue is that enabling this on Rococo makes 26 benchmarks fail, so have to debug those first 🙃
@ggwpez ggwpez added the T12-benchmarks This PR/Issue is related to benchmarking and weights. label Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T12-benchmarks This PR/Issue is related to benchmarking and weights.
Projects
Benchmarking and Weights
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ggwpez