subsystem-bench: Extract prometheus endpoint launching from regression test cases to use it only with cli runner #3600
Labels
C1-mentor
A task where a mentor is available. Please indicate in the issue who the mentor could be.
C2-good-first-issue
A task for a first time contributor to become familiar with the Polkadot-SDK.
R0-silent
Changes should not be mentioned in any release notes
T12-benchmarks
This PR/Issue is related to benchmarking and weights.
We use an awkward
false
argument to not initialize a prometheus endpoint inside regression tests. Otherwise, each test will start an unconfigurable endpoint, causing errors because they will use the same port 9999.polkadot-sdk/polkadot/node/network/availability-recovery/tests/availability-recovery-regression-bench.rs
Line 100 in 475e7a1
It's better to extract the endpoint launching outside the test, as we already do with
valgrind
andpyroscope
. But we still use prometheus inside the tests.polkadot-sdk/polkadot/node/subsystem-bench/src/cli/subsystem-bench.rs
Lines 108 to 121 in 475e7a1
The text was updated successfully, but these errors were encountered: