Skip to content
This repository has been archived by the owner on Oct 11, 2023. It is now read-only.

Review logging levels for the sake of meaningful alerts #316

Open
joao-paulo-parity opened this issue Oct 8, 2021 · 0 comments
Open

Review logging levels for the sake of meaningful alerts #316

joao-paulo-parity opened this issue Oct 8, 2021 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@joao-paulo-parity
Copy link
Contributor

At the moment we're not able to get meaningful error alerts because the logging error levels are not being used properly. For instance, the following is not related to an application failure necessarily (e.g. could be a Github API failure) but it still logged as log::error regardless.

log::error!("handle_error: {}", e);

After the logging call sites are thoroughly reviewed, we'll be able to request processbot alerts from DevOps (like it was done for try-runtime-bot in https://github.com/paritytech/devops/issues/1026).

@Vovke Vovke added duplicate This issue or pull request already exists and removed duplicate This issue or pull request already exists labels Apr 12, 2022
@joao-paulo-parity joao-paulo-parity added enhancement New feature or request good first issue Good for newcomers labels Apr 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants