Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass relay balance guard value using cli parameter #2478

Closed
svyatonik opened this issue Feb 3, 2022 · 1 comment
Closed

Pass relay balance guard value using cli parameter #2478

svyatonik opened this issue Feb 3, 2022 · 1 comment

Comments

@svyatonik
Copy link
Contributor

Right now values for balance guards are hardcoded (e.g.

pub(crate) const MAXIMAL_BALANCE_DECREASE_PER_DAY: bp_polkadot::Balance = 30_000_000_000;
,
pub(crate) const MAXIMAL_BALANCE_DECREASE_PER_DAY: bp_polkadot::Balance = 100_000_000_000;
and so on). But actually this value is different in different relay modes. Some values are now computed for relay-headers mode, when relay is (roughly) syncing all headers. Some - for the obsolete version of --only-mandatory-headers mode, when relay has been relaying mandatory headers and paid for it (now: submitting mandatory headers is free). But e.g. when we start relay in --relay-headers-and-messages mode we don't know in advance how many tokens relay may lose/gain. So for every development it makes sense to customize this value.

related to #1300

@serban300
Copy link
Collaborator

Might also be related to #2416

svyatonik referenced this issue Jul 17, 2023
This is basically a hack, but with the current way we initialize the node this is the easiest
solution to ensure we send the correct version etc.
@EmmanuellNorbertTulbure EmmanuellNorbertTulbure transferred this issue from paritytech/parity-bridges-common Aug 25, 2023
@the-right-joyce the-right-joyce transferred this issue from paritytech/polkadot-sdk Aug 25, 2023
@EmmanuellNorbertTulbure EmmanuellNorbertTulbure closed this as not planned Won't fix, can't repro, duplicate, stale Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants