Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[proc macros]: annoyance to require log crate to make it compile #467

Closed
Tracked by #492
niklasad1 opened this issue Sep 15, 2021 · 1 comment · Fixed by #555
Closed
Tracked by #492

[proc macros]: annoyance to require log crate to make it compile #467

niklasad1 opened this issue Sep 15, 2021 · 1 comment · Fixed by #555

Comments

@niklasad1
Copy link
Member

With the introduced logging for example when a parsing JSON-RPC parameters failed which is very useful but it forces users that have log as hard dependency otherwise it won't compile.

Can we do something about such as hide it behind some feature flag @dvdplm?
@dvdplm
Copy link
Contributor

dvdplm commented Sep 15, 2021

Do you think re-exporting log in the macros would work?

@dvdplm dvdplm mentioned this issue Oct 1, 2021
Closed
10 tasks
@maciejhirsz maciejhirsz mentioned this issue Nov 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Re-export tracing for macros paritytech/jsonrpsee
2 participants
@dvdplm @niklasad1