Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to async / await #124

Open
andresilva opened this issue Jul 31, 2020 · 0 comments
Open

Refactor to async / await #124

andresilva opened this issue Jul 31, 2020 · 0 comments

Comments

@andresilva
Copy link
Contributor

When this crate was initially designed there was no async/await support, as a result the asynchronous logic in this crate is implemented with custom Future impls.

Recently we wanted to make some of the methods on Environment async, e.g. round_data should return a Future as it requires a call to a keystore that may be remote. This small change propagates throughout the crate (e.g. Voter::new needs to become asynchronous) and is not amenable to the current architecture. A redesign to use async/await and not rely on Future implementations would make this change easier to implement.

@andresilva andresilva changed the title Refactor into async / await Refactor for async / await Jul 31, 2020
@andresilva andresilva changed the title Refactor for async / await Refactor to async / await Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant