-
Notifications
You must be signed in to change notification settings - Fork 380
Conversation
@@ -21,21 +21,26 @@ use sp_runtime::traits::{Block as BlockT, Hash as HashT, Header as HeaderT, Zero | |||
/// Generate the genesis block from a given ChainSpec. | |||
pub fn generate_genesis_block<Block: BlockT>( | |||
chain_spec: &Box<dyn ChainSpec>, | |||
genesis_state_version: sp_runtime::StateVersion, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we not fetch the runtime version from the code in the genesis state? As we do this in Substrate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was my first idea, but current code need an executor (for compatibility I think), so ends up being really easier to use this way.
You think it is a must have, or can we keep it this way (seems only use from commands at this point)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, this is not really future proof.
@@ -60,6 +60,7 @@ pub const VERSION: RuntimeVersion = RuntimeVersion { | |||
impl_version: 0, | |||
apis: RUNTIME_API_VERSIONS, | |||
transaction_version: 1, | |||
state_version: 1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
state_version: 1, | |
state_version: 0, |
Probably too late.
Waiting for commit status. |
Merge cancelled due to error. Error: Checks failed for 05e0861 |
Waiting for commit status. |
Merge cancelled due to error. Error: Checks failed for 7869bae |
bot merge |
companion for paritytech/substrate#9732