Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Refactor paths and runtime names #507

Merged
merged 3 commits into from
Jun 28, 2021
Merged

Conversation

chevdor
Copy link
Contributor

@chevdor chevdor commented Jun 24, 2021

This PR renames the rococo runtime to follow the pattern used by all other chains (in this repo and the pollkadot repo).

The PR also uses the same folder tree (= runtimes under a runtime/<name>) folder. That simplifies tooling and allows building all the runtimes the same way.

Once this PR is merged, I will be able to extend the CI to build statemint, shell and rococo using srtool (see #509)

Copy link
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be fine to move this to polkadot-parachains/runtime/*, but not moving it to the top

@chevdor
Copy link
Contributor Author

chevdor commented Jun 24, 2021

That works for me. The most important is that:

  • the rococo runtime is named rococo-runtime
  • the runtime <foobar> in the runtime_dir (in our case polkadot-parachains or polkadot-parachains/runtimes) as a foobar folder (vs foobar-runtime currently).

It is easier if the runtime_dir is a folder called runtime as in Polkadot but having it a level down as you suggest is not a big issue.

Let me adjust to your suggestion.

@chevdor
Copy link
Contributor Author

chevdor commented Jun 24, 2021

I don't see a benefit going from polkadot-parachains/* to polkadot-parachains/runtime/* so I will bring the runtimes back to polkadot-parachains/*

@chevdor
Copy link
Contributor Author

chevdor commented Jun 24, 2021

@bkchr would that work for you now ?

polkadot-parachains/Cargo.toml Outdated Show resolved Hide resolved
@bkchr
Copy link
Member

bkchr commented Jun 28, 2021

bot merge

@ghost
Copy link

ghost commented Jun 28, 2021

Trying merge.

@ghost
Copy link

ghost commented Jun 28, 2021

Merge failed with response status: 403 Forbidden and body: {"documentation_url":"https://docs.github.com/rest/reference/pulls#merge-a-pull-request","message":"Resource not accessible by integration"}

@chevdor chevdor merged commit 35738c7 into paritytech:master Jun 28, 2021
@chevdor chevdor deleted the wk-refactor branch July 6, 2021 13:55
slumber pushed a commit that referenced this pull request Sep 1, 2021
chore: refactor for consistant naming of the crates and paths of the runtimes

* tests: ignore folder created by the tests
* chore: refactoring
* Update polkadot-parachains/Cargo.toml

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants