This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Make CI work #1079
Merged
Make CI work #1079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MR#1076 somehow broke the check-runtime-benchmarks CI. Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
ggwpez
added
A3-inprogress
A2-insubstantial
Member
|
It broke because you added the crate without enabling the feature. |
bkchr
approved these changes
Mar 11, 2022
Member
bkchr
left a comment
bkchr
left a comment
There was a problem hiding this comment.
We can merge this to make the CI work again. However, you should then prepare a new pr to address my late comments on your other pr.
Member
Author
|
bot merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1076 somehow broke the check-runtime-benchmarks CI after failing to merge as companion and being force merged.