Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Burning fee allowed for system parachain? #2320

Open
xlc opened this issue Mar 15, 2023 · 3 comments
Open

Burning fee allowed for system parachain? #2320

xlc opened this issue Mar 15, 2023 · 3 comments
Labels
T1-runtime This PR/Issue is related to the topic “runtime”. T6-XCM This PR/Issue is related to XCM.

Comments

@xlc
Copy link
Contributor

xlc commented Mar 15, 2023

To my understanding, this will burn all XCM fees.

Two questions:

  • Shouldn't fee be sent to collator?
  • Can system parachain allowed to burn relaychain tokens (without notifying relaychain)? Wouldn't this cause imbalances? i.e. balance mismatch between relaychain's checking account and parachain's total issuance.
@joepetrowski
Copy link
Contributor

Yes, I agree

@joepetrowski joepetrowski added T6-XCM This PR/Issue is related to XCM. T1-runtime This PR/Issue is related to the topic “runtime”. labels Mar 21, 2023
@gavofyork
Copy link
Member

Yes, when FeeManager is used, they would be better sent to a proper account.

@gilescope
Copy link
Contributor

Talking with Gav, it's best if the fees get accrued in the chain's treasury / a holding account rather than it going to collators. He said the only real question is the degree of aggregation:

  1. No aggregation: use AssetTransactor directly in FeeManager.

  2. Aggregate over XCVM execution: accrue in an XCVM MultiAssets (Holding-like) register and use AssetTransactor to disperse assets at the end of the XCVM execution.

  3. Aggregate over block: accrue in a temporary MultiAssets storage item in pallet-xcm and place assets into accounts via a permissionless transaction (a "task", in the new lexicon) and AssetTransactor.

  4. Aggregate indefinitely: accrue in a permanent MultiAssets storage item in pallet-xcm and allow a specific XCM origin to call ClaimAsset to claim them.

Option 1 is the easiest to implement, so we will do that initially but the others should be implemented eventually.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T1-runtime This PR/Issue is related to the topic “runtime”. T6-XCM This PR/Issue is related to XCM.
Projects
None yet
Development

No branches or pull requests

4 participants