Pull requests are welcomed! Here’s a quick guide:
-
Fork the repo.
-
Run the tests. We only take pull requests with passing tests, and it's great to know that you have a clean slate:
bundle && rake
-
Add a test for your change. Only refactoring and documentation changes require no new tests. If you are adding functionality or fixing a bug, we need a test!
-
Make the test pass.
-
Push to your fork and submit a pull request.
- Accuracy over speed
- Functionality over style
- One installation step (through
gem
orbundle
) - Minimal runtime dependencies (beyond the standard libraries)
- Effective collaboration (and minimized interpersonal conflict)
- Sustainability and maintainability (this isn’t a full-time project)
See also: rake rubocop
- Two spaces, no tabs.
- No trailing whitespace. Blank lines should not have any space.
- Prefer
&& ||
overand or
. - Use
MyClass.my_method(my_arg)
notmy_method( my_arg )
ormy_method my_arg
. - Prefer
a = b
toa=b
. - Follow the conventions you see used in the source already.