Allow spaces in filenames (#1212)

parcel-bundler · Apr 29, 2018 · fb6912d · fb6912d
1 parent 19b9fc6
commit fb6912d
Show file tree

Hide file tree

Showing 5 changed files with 33 additions and 2 deletions.
diff --git a/src/Asset.js b/src/Asset.js
@@ -88,7 +88,10 @@ class Asset {
     }
 
     const parsed = URL.parse(url);
-    const resolved = path.resolve(path.dirname(from), parsed.pathname);
+    const resolved = path.resolve(
+      path.dirname(from),
+      decodeURIComponent(parsed.pathname)
+    );
     this.addDependency(
       './' + path.relative(path.dirname(this.name), resolved),
       Object.assign({dynamic: true}, opts)

diff --git a/src/assets/HTMLAsset.js b/src/assets/HTMLAsset.js
@@ -87,7 +87,7 @@ class HTMLAsset extends Asset {
   }
 
   processSingleDependency(path, opts) {
-    let assetPath = this.addURLDependency(decodeURIComponent(path), opts);
+    let assetPath = this.addURLDependency(path, opts);
     if (!isURL(assetPath)) {
       assetPath = urlJoin(this.options.publicURL, assetPath);
     }

diff --git a/test/html.js b/test/html.js
@@ -560,4 +560,20 @@ describe('html', function() {
       ]
     });
   });
+
+  it('should resolve assets containing spaces', async function() {
+    let b = await bundle(__dirname + '/integration/resolve-spaces/index.html');
+
+    assertBundleTree(b, {
+      name: 'index.html',
+      assets: ['index.html'],
+      childBundles: [
+        {
+          type: 'html',
+          assets: ['other page.html'],
+          childBundles: []
+        }
+      ]
+    });
+  });
 });
diff --git a/test/integration/resolve-spaces/index.html b/test/integration/resolve-spaces/index.html
@@ -0,0 +1,6 @@
+<!doctype html>
+<html>
+<body>
+    <a href="other page.html">other page</a>
+</body>
+</html>
diff --git a/test/integration/resolve-spaces/other page.html b/test/integration/resolve-spaces/other page.html
@@ -0,0 +1,6 @@
+<!doctype html>
+<html>
+<body>
+  <a href="index.html">index</a>
+</body>
+</html>