Skip to content

Upgrade to vue 3 component #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 4, 2022
Merged

Upgrade to vue 3 component #20

merged 10 commits into from
Jul 4, 2022

Conversation

tolgap
Copy link
Member

@tolgap tolgap commented Feb 8, 2021

Vue 3 has a number of changes:

  • No more functional components. Instead, just create a function that returns the VNodes.
  • Render functions don't receive h anymore. h is now an export of vue which forces library authors to figure out how to depend on vue exports, without bundling the entirety of Vue into your library
  • Exposed an issue of unnecessary rendering when using custom nodeRenderers, which prompted the usage of readonly richtext document

Fixes #18

@tolgap tolgap self-assigned this Feb 8, 2021
@hturnbull93
Copy link

hturnbull93 commented Jul 4, 2022

Hi there @tolgap ! I hope you are well.

Now that Vue3 is released, shall this be merged and released?

It appears to work fine with my Vue3/Nuxt3 project, though it does suffer from faulty ESM export as described in this issue (though this is minor, I can import the cjs)

@tolgap tolgap merged commit 2f764bc into master Jul 4, 2022
@tolgap tolgap deleted the vue3 branch July 4, 2022 17:02
@tolgap
Copy link
Member Author

tolgap commented Jul 4, 2022

@hturnbull93 thanks for reminding me! Released as 3.0.0 🎉 .

@hturnbull93
Copy link

@tolgap Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vue 3
2 participants