Added total headings count to unique-headings rule (fixes CSSLint#108)

Author: Nicholas C. Zakas

CHANGELOG

@@ -1,5 +1,6 @@
 Next (not yet released)
 
+* Added total headings count to unique-headings rule (fixes #108)
 * Fixed bug with box model rule (fixes #135)
 * Added rule to check property name against list of known properties (fixes #136)
 * Ensure consistency across error messages (fixes #89)

src/rules/unique-headings.js

@@ -32,14 +32,31 @@ CSSLint.addRule({
                 selector = selectors[i];
                 part = selector.parts[selector.parts.length-1];
 
-                if (part.elementName && /(h[1-6])/.test(part.elementName.toString())){
+                if (part.elementName && /(h[1-6])/i.test(part.elementName.toString())){
                     headings[RegExp.$1]++;
                     if (headings[RegExp.$1] > 1) {
                         reporter.warn("Heading (" + part.elementName + ") has already been defined.", part.line, part.col, rule);
                     }
                 }
             }
         });
+        
+        parser.addListener("endstylesheet", function(event){
+            var prop,
+                messages = [];
+                
+            for (var prop in headings){
+                if (headings.hasOwnProperty(prop)){
+                    if (headings[prop] > 1){
+                        messages.push(headings[prop] + " " + prop + "s");
+                    }
+                }
+            }
+            
+            if (messages.length){
+                reporter.rollupWarn("You have " + messages.join(", ") + " defined in this stylesheet.", rule);
+            }
+        });        
     }
 
 });

tests/rules/unique-headings.js

@@ -7,11 +7,24 @@
 
         name: "Unique Headings Errors",
 
-        "Defining two rules for h1 should result in one warning": function(){
+        "Defining two rules for h1 should result in two warnings": function(){
             var result = CSSLint.verify("h1 { color: red;} h1 {color: blue;}", { "unique-headings": 1 });
-            Assert.areEqual(1, result.messages.length);
+            Assert.areEqual(2, result.messages.length);
             Assert.areEqual("warning", result.messages[0].type);
             Assert.areEqual("Heading (h1) has already been defined.", result.messages[0].message);
+            Assert.areEqual("warning", result.messages[1].type);
+            Assert.areEqual("You have 2 h1s defined in this stylesheet.", result.messages[1].message);
+        },
+
+        "Defining two rules for h1 and h2 should result in one warning": function(){
+            var result = CSSLint.verify("h1 { color: red;} h1 {color: blue;} h2 { color: red;} h2 {color: blue;}", { "unique-headings": 1 });
+            Assert.areEqual(3, result.messages.length);
+            Assert.areEqual("warning", result.messages[0].type);
+            Assert.areEqual("Heading (h1) has already been defined.", result.messages[0].message);
+            Assert.areEqual("warning", result.messages[1].type);
+            Assert.areEqual("Heading (h2) has already been defined.", result.messages[1].message);
+            Assert.areEqual("warning", result.messages[2].type);
+            Assert.areEqual("You have 2 h1s, 2 h2s defined in this stylesheet.", result.messages[2].message);
         },
 
          "Defining one rule for h1 should not result in a warning": function(){