Add support for compiling the provider on aarch64 #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomás González <tomasagustin.gonzalezorlando@arm.com>
Signed-off-by: Tomás González <tomasagustin.gonzalezorlando@arm.com>
minosgalanakis
approved these changes
May 23, 2024
| @@ -0,0 +1,45 @@ | |||
| # Copyright 2024 Contributors to the Parsec project. | |||
| # SPDX-License-Identifier: Apache-2.0 | |||
| FROM ubuntu:22.04 | |||
There was a problem hiding this comment.
in the ci.yaml it refers
build-and-test:
name: Build Parsec OpenSSL Provider and run tests
runs-on: ubuntu-latest
I am not sure how the workflow's work but couldn't pinning the version down in Docker cause any issues in the future ?
There was a problem hiding this comment.
The parsec-openssl-provider-cross-compile docker image is the one we run our cross compilation on.
This docker container runs on a Github runner instance that has version ubuntu-latest. Please see this link for the available options (currently Ubuntu 22.04).
We want to be pinning down the cross compilation docker image for reproducibility, but we want our Github runner instances to be as updated as possible if that makes sense. We have been operating this way for all of parallaxsecond projects (parsec, parsec-tool, etc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide: