Revert Key Objects Data validation #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgonzalezorlandoarm
force-pushed
the
tg/disable-validate
branch
from
dd15415 to
bdfff49
Compare
The current implementation of OSSL_FUNC_KEYMGMT_VALIDATE is incomplete and requires some work. The TLS handshake on openssl won't require this functionality being implemented. As a result, OSSL_FUNC_KEYMGMT_VALIDATE won't be finished in the near future, until we implement we have the TLS handshake working. * Remove the implementation of the validation function as the current implementation is too incomplete and not removing it may bring more maintainance effort in the future. This reverts commit 155b860. Signed-off-by: Tomás González <tomasagustin.gonzalezorlando@arm.com>
The current implementation of OSSL_FUNC_KEYMGMT_VALIDATE is incomplete and requires some work. The TLS handshake on openssl won't require this functionality being implemented. As a result, OSSL_FUNC_KEYMGMT_VALIDATE won't be finished in the near future, until we implement we have the TLS handshake working. * Remove the unit test for the validation function as the current implementation is too incomplete and not removing it may bring more maintainance effort in the future. The test can be re-enabled and altered when the correct implementation is performed. This reverts commit 9e16fec. Signed-off-by: Tomás González <tomasagustin.gonzalezorlando@arm.com>
tgonzalezorlandoarm
force-pushed
the
tg/disable-validate
branch
from
bdfff49 to
410bf81
Compare
gowthamsk-arm
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of OSSL_FUNC_KEYMGMT_VALIDATE is incomplete and requires some work.
The TLS handshake on openssl won't require this functionality being implemented.
As a result, OSSL_FUNC_KEYMGMT_VALIDATE won't be finished in the near future, until we implement we have the TLS handshake working.
This reverts commits 155b860 and 9e16fec.