signature: Add Signature operation for RSA #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgonzalezorlandoarm
force-pushed
the
tg/signature-sign
branch
2 times, most recently
from
40d0d6c to
df89469
Compare
tgonzalezorlandoarm
force-pushed
the
tg/signature-sign
branch
2 times, most recently
from
58e803b to
765b474
Compare
tgonzalezorlandoarm
force-pushed
the
tg/signature-sign
branch
3 times, most recently
from
6d70f8d to
14c2b26
Compare
|
Can you add a test case for sig is NULL condition? |
Implement: * OSSL_FUNC_SIGNATURE_SIGN as indicated by https://www.openssl.org/docs/man3.0/man7/provider-signature.html Signed-off-by: Tomás González <tomasagustin.gonzalezorlando@arm.com>
tgonzalezorlandoarm
force-pushed
the
tg/signature-sign
branch
2 times, most recently
from
bf5a9cb to
720c8b7
Compare
Done |
According to: https://www.openssl.org/docs/man3.0/man7/provider-signature.html "If sig is NULL then the maximum length of the signature should be written to *siglen." * Add some checks to test this functionality Signed-off-by: Tomás González <tomasagustin.gonzalezorlando@arm.com>
Test is now passing as sign() has been implemented for RSA Signed-off-by: Tomás González <tomasagustin.gonzalezorlando@arm.com>
tgonzalezorlandoarm
force-pushed
the
tg/signature-sign
branch
from
720c8b7 to
9491a93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RSA sign test is now passing
Depends on #42