Keymgmt import: Add a key presence check #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgonzalezorlandoarm
force-pushed
the
tg/keymgmt-import-extended
branch
2 times, most recently
from
c49e476 to
0caa8ce
Compare
| if keys.iter().any(|kinfo| kinfo.name == key_name) { | ||
| Ok(OPENSSL_SUCCESS) | ||
| } else { | ||
| Err("Failed to list Parsec Provider's Keys".into()) |
There was a problem hiding this comment.
The error log should rather be,
"Key is not existing in the Parsec Service"?
The kmgmt_import function loads certain data in the keydata. Before doing this, check if the reffered to key is present in the provider. Signed-off-by: Tomás González <tomasagustin.gonzalezorlando@arm.com>
Signed-off-by: Tomás González <tomasagustin.gonzalezorlando@arm.com>
tgonzalezorlandoarm
force-pushed
the
tg/keymgmt-import-extended
branch
from
0caa8ce to
325e75b
Compare
gowthamsk-arm
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kmgmt_import function loads certain data in the keydata.
Before doing this, check if the reffered to key is present in the provider.
Depends on #29