- 
                Notifications
    You must be signed in to change notification settings 
- Fork 1
keymgmt: Add Key Objects checks for filled data #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    df794e0    to
    a5ff12e      
    Compare
  
    a5ff12e    to
    9fbf0c4      
    Compare
  
    Implement: 1. OSSL_FUNC_KEYMGMT_HAS for key objects as indicated by https://www.openssl.org/docs/man3.0/man7/provider-keymgmt.html This currently only checks whether selection is 'OSSL_KEYMGMT_SELECT_OTHER_PARAMETERS' and the key_name has been filled, as currently we don't support any other selection/data in Key Objects. Signed-off-by: Tomás González <tomasagustin.gonzalezorlando@arm.com>
e4a20de    to
    d1899cc      
    Compare
  
    Checks the behaviour of OSSL_FUNC_KEYMGMT_HAS Signed-off-by: Tomás González <tomasagustin.gonzalezorlando@arm.com>
provider needs to stay in scope, so it still needs to remain bound, but we are not using the variable per se. Signed-off-by: Tomás González <tomasagustin.gonzalezorlando@arm.com>
d1899cc    to
    c3fc7e9      
    Compare
  
    
              
                    gowthamsk-arm
  
              
              approved these changes
              
                  
                    Apr 5, 2024 
                  
              
              
            
            
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Implement:
for key objects as indicated by
https://www.openssl.org/docs/man3.0/man7/provider-keymgmt.html
This currently only checks whether selection is
'OSSL_KEYMGMT_SELECT_OTHER_PARAMETERS' and the key_name has been filled, as currently we don't support any other selection/data in Key Objects.