Skip to content

Commit 573f679

Browse files
signature: Enable ECDSA signing
* Populate the ECDSA signing implementation table * Enable the ECDSA signing test that was previously being ignored * + Minor logging improvement Signed-off-by: Tomás González <tomasagustin.gonzalezorlando@arm.com>
1 parent 720c8b7 commit 573f679

File tree

2 files changed

+4
-6
lines changed
  • parsec-openssl-provider-shared/e2e_tests/tests
  • parsec-openssl-provider/src/signature

2 files changed

+4
-6
lines changed

parsec-openssl-provider-shared/e2e_tests/tests/sign.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,6 @@ fn sign_verify(
9999
Ok(())
100100
}
101101

102-
#[ignore]
103102
#[test]
104103
fn test_signing_ecdsa() {
105104
// Create a key beforehand using the parsec-tool and then run the test.

parsec-openssl-provider/src/signature/mod.rs

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,7 @@ unsafe extern "C" fn parsec_provider_signature_sign(
184184
.get_provctx()
185185
.get_client()
186186
.psa_sign_hash(key_name, tbs_slice, sign_algorithm)
187-
.map_err(|_| "Parsec Client failed to sign".to_string())?;
187+
.map_err(|e| format!("Parsec Client failed to sign: {:?}", e))?;
188188

189189
if sigsize >= sign_res.len() as u32 {
190190
std::ptr::copy(sign_res.as_ptr(), sig, sign_res.len());
@@ -224,8 +224,7 @@ const OSSL_FUNC_SIGNATURE_FREECTX_PTR: SignatureFreeCtxPtr = parsec_provider_sig
224224
const OSSL_FUNC_SIGNATURE_SIGN_PTR: SignatureSignPtr = parsec_provider_signature_sign;
225225
const OSSL_FUNC_SIGNATURE_SIGN_INIT_PTR: SignatureSignInitPtr = parsec_provider_signature_sign_init;
226226

227-
const PARSEC_PROVIDER_ECDSA_SIGN_IMPL: [OSSL_DISPATCH; 1] = [ossl_dispatch!()];
228-
const PARSEC_PROVIDER_RSA_SIGN_IMPL: [OSSL_DISPATCH; 5] = [
227+
const PARSEC_PROVIDER_SIGN_IMPL: [OSSL_DISPATCH; 5] = [
229228
unsafe { ossl_dispatch!(OSSL_FUNC_SIGNATURE_NEWCTX, OSSL_FUNC_SIGNATURE_NEWCTX_PTR) },
230229
unsafe { ossl_dispatch!(OSSL_FUNC_SIGNATURE_FREECTX, OSSL_FUNC_SIGNATURE_FREECTX_PTR) },
231230
unsafe { ossl_dispatch!(OSSL_FUNC_SIGNATURE_SIGN, OSSL_FUNC_SIGNATURE_SIGN_PTR) },
@@ -242,13 +241,13 @@ pub const PARSEC_PROVIDER_SIGNATURE: [OSSL_ALGORITHM; 3] = [
242241
ossl_algorithm!(
243242
PARSEC_PROVIDER_ECDSA_NAME,
244243
PARSEC_PROVIDER_DFLT_PROPERTIES,
245-
PARSEC_PROVIDER_ECDSA_SIGN_IMPL,
244+
PARSEC_PROVIDER_SIGN_IMPL,
246245
PARSEC_PROVIDER_DESCRIPTION_ECDSA
247246
),
248247
ossl_algorithm!(
249248
PARSEC_PROVIDER_RSA_NAME,
250249
PARSEC_PROVIDER_DFLT_PROPERTIES,
251-
PARSEC_PROVIDER_RSA_SIGN_IMPL,
250+
PARSEC_PROVIDER_SIGN_IMPL,
252251
PARSEC_PROVIDER_DESCRIPTION_RSA
253252
),
254253
ossl_algorithm!(),

0 commit comments

Comments
 (0)