Skip to content

Commit 812fc78

Browse files
authored
remove saucelabs credentials (#3776)
1 parent f3c69ad commit 812fc78

File tree

4 files changed

+8
-18
lines changed

4 files changed

+8
-18
lines changed

.github/workflows/continuous-integration.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
name: Continous Integration
1+
name: Continuous Integration
22

3-
on: [push, pull_request]
3+
on: [pull_request_target]
44

55
jobs:
66
test-saucelabs:

.sauce.yml

Lines changed: 0 additions & 4 deletions
This file was deleted.

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,6 @@
5757
"jasmine": "3.5.0",
5858
"jasmine-core": "3.5.0",
5959
"jasmine-expect": "4.0.3",
60-
"js-yaml": "3.13.1",
6160
"jsdoc": "^3.6.3",
6261
"karma": "5.1.0",
6362
"karma-babel-preprocessor": "8.0.1",

test/saucelabs/karma.conf.js

Lines changed: 6 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
// Karma configuration
22
"use strict";
3-
const yaml = require("js-yaml");
4-
const fs = require("fs");
53
const karmaConfig = require("../karma.common.conf.js");
64

75
const browsers = {
@@ -25,24 +23,21 @@ const browsers = {
2523
};
2624

2725
module.exports = config => {
28-
// Use ENV vars or .sauce.yml to get credentials
26+
// re-defining the env variables seems to fix the auth issue
27+
// eslint-disable-next-line no-self-assign
28+
process.env.SAUCE_USERNAME = process.env.SAUCE_USERNAME
29+
// eslint-disable-next-line no-self-assign
30+
process.env.SAUCE_ACCESS_KEY = process.env.SAUCE_ACCESS_KEY
2931
if (
3032
!(
3133
process.env.SAUCE_USERNAME &&
3234
process.env.SAUCE_ACCESS_KEY &&
3335
process.env.SAUCE_ACCESS_KEY.length > 5
3436
)
3537
) {
36-
if (!fs.existsSync(".sauce.yml")) {
3738
// eslint-disable-next-line no-console
38-
console.log("Create a .sauce.yml with your credentials");
39+
console.error("Saucelabs credentials are missing. Define the SAUCE_USERNAME and SAUCE_ACCESS_KEY environment variables.");
3940
process.exit(1);
40-
} else {
41-
let sauceConfig = yaml.safeLoad(fs.readFileSync(".sauce.yml", "utf8"));
42-
process.env.SAUCE_USERNAME = sauceConfig.addons.sauce_connect.username;
43-
process.env.SAUCE_ACCESS_KEY =
44-
sauceConfig.addons.sauce_connect.access_key;
45-
}
4641
}
4742
config.set({
4843
...karmaConfig,

0 commit comments

Comments
 (0)