Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove consensus generic #4981

Merged
merged 1 commit into from
Oct 11, 2023
Merged

chore: remove consensus generic #4981

merged 1 commit into from
Oct 11, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Oct 11, 2023

this gets rid of the C: Consensus generic of the tree,

we're using Arc<dyn Consensus> during the node command setup anyway, so we can just use this in the tree as well

@mattsse mattsse added the C-debt Refactor of code section that is hard to understand or maintain label Oct 11, 2023
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #4981 (5824017) into main (e042922) will decrease coverage by 0.04%.
The diff coverage is 91.30%.

Impacted file tree graph

Files Coverage Δ
crates/blockchain-tree/src/blockchain_tree.rs 83.77% <100.00%> (-0.30%) ⬇️
crates/blockchain-tree/src/externals.rs 91.66% <100.00%> (+5.95%) ⬆️
crates/blockchain-tree/src/shareable.rs 56.52% <100.00%> (ø)
crates/consensus/beacon/src/engine/test_utils.rs 64.37% <100.00%> (-2.62%) ⬇️
crates/blockchain-tree/src/chain.rs 77.20% <83.33%> (-0.17%) ⬇️

... and 9 files with indirect coverage changes

Flag Coverage Δ
integration-tests 15.43% <0.00%> (-0.01%) ⬇️
unit-tests 62.47% <91.30%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 30.63% <ø> (ø)
blockchain tree 80.54% <90.90%> (-0.09%) ⬇️
pipeline 88.45% <ø> (ø)
storage (db) 74.39% <ø> (-0.01%) ⬇️
trie 94.48% <ø> (-0.04%) ⬇️
txpool 48.52% <ø> (ø)
networking 76.07% <ø> (-0.06%) ⬇️
rpc 58.03% <ø> (-0.01%) ⬇️
consensus 62.82% <100.00%> (-0.20%) ⬇️
revm 27.79% <ø> (ø)
payload builder 7.96% <ø> (ø)
primitives 86.28% <ø> (-0.09%) ⬇️

Copy link
Collaborator

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clean! lgtm

@rakita rakita added this pull request to the merge queue Oct 11, 2023
@rakita rakita added the A-blockchain-tree Related to sidechains, reorgs and pending blocks label Oct 11, 2023
Merged via the queue into main with commit 00a92f5 Oct 11, 2023
23 checks passed
@rakita rakita deleted the matt/remove-consensus-generic branch October 11, 2023 12:56
mattsse added a commit that referenced this pull request Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-blockchain-tree Related to sidechains, reorgs and pending blocks C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants